Pin Redis-py version#946
Merged
Merged
Conversation
Redis-py 3.0.0 was released today and introduced a backwards incompatible changes. https://github.com/andymccurdy/redis-py/blob/9b03af26dc829beea232a3248768de933f4c3b67/CHANGES#L27-L29 This isn't the "best" fix but is the quickest
Codecov Report
@@ Coverage Diff @@
## master #946 +/- ##
=======================================
Coverage 88.66% 88.66%
=======================================
Files 63 63
Lines 6509 6509
Branches 776 776
=======================================
Hits 5771 5771
Misses 656 656
Partials 82 82Continue to review full report at Codecov.
|
6 tasks
Contributor
|
Thanks! |
Contributor
Author
|
I think the interface to
I.e. I think
needs to become
|
Contributor
Author
|
In the mean time what is the chance of getting a quick Kombu release out with this version pin included? |
Contributor
|
I'll try to get to it. |
Contributor
Author
|
Could it be helpful if I opened a PR that fixes this properly and supports redis-py v2 and v2 concurrently? (Thinking about ease of upgrading for users of celery, who are often not installing kobu directly, or don't do |
ashb
added a commit
to ashb/kombu
that referenced
this pull request
Nov 16, 2018
Further to celery#946 this fixes the underlying issue in a easy-to-upgrade way for end users, many of whom will have redis installed via other means. By having this check here and supporting both versions concurrently it makes it easier for end users, and to use celery/kombu in projects that use redis elsewhere. With this change it is possibly worth reverting celery#946
ashb
added a commit
to ashb/kombu
that referenced
this pull request
Nov 18, 2018
Further to celery#946 this fixes the underlying issue in a easy-to-upgrade way for end users, many of whom will have Redis installed via other means. By having this check here and supporting both versions concurrently it makes it easier for end users, and to use celery/kombu in projects that use Redis elsewhere. With this change it is possibly worth reverting celery#946
ashb
added a commit
to ashb/kombu
that referenced
this pull request
Nov 19, 2018
Further to celery#946 this fixes the underlying issue in a easy-to-upgrade way for end users, many of whom will have Redis installed via other means. By having this check here and supporting both versions concurrently it makes it easier for end users, and to use celery/kombu in projects that use Redis elsewhere. With this change it is possibly worth reverting celery#946
ashb
added a commit
to ashb/kombu
that referenced
this pull request
Nov 19, 2018
Further to celery#946 this fixes the underlying issue in a easy-to-upgrade way for end users, many of whom will have Redis installed via other means. By having this check here and supporting both versions concurrently it makes it easier for end users, and to use celery/kombu in projects that use Redis elsewhere. With this change it is possibly worth reverting celery#946
thedrow
pushed a commit
that referenced
this pull request
Nov 19, 2018
Further to #946 this fixes the underlying issue in a easy-to-upgrade way for end users, many of whom will have Redis installed via other means. By having this check here and supporting both versions concurrently it makes it easier for end users, and to use celery/kombu in projects that use Redis elsewhere. With this change it is possibly worth reverting #946
thedrow
added a commit
that referenced
this pull request
Nov 19, 2018
thedrow
pushed a commit
that referenced
this pull request
Dec 6, 2018
Further to #946 this fixes the underlying issue in a easy-to-upgrade way for end users, many of whom will have Redis installed via other means. By having this check here and supporting both versions concurrently it makes it easier for end users, and to use celery/kombu in projects that use Redis elsewhere. With this change it is possibly worth reverting #946
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redis-py 3.0.0 was released today and introduced a backwards incompatible changes.
https://github.com/andymccurdy/redis-py/blob/9b03af26dc829beea232a3248768de933f4c3b67/CHANGES#L27-L29
This isn't the "best" fix but is the quickest.