Repository navigation
Stop channel retries at the same max_retries bound as connections - #2671
Merged
Merged
Conversation
ensure() used retries > max_retries for channel errors, so they got one extra attempt. Connection errors already stop at retries >= max_retries.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2671 +/- ##
=======================================
Coverage 83.91% 83.92%
=======================================
Files 80 80
Lines 11208 11208
Branches 1341 1341
=======================================
+ Hits 9405 9406 +1
+ Misses 1585 1584 -1
Partials 218 218 ☔ View full report in Codecov by Harness. |
auvipy
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connection.ensurestops connection errors whenretries >= max_retries(one attempt plusmax_retries). Channel errors usedretries > max_retries, so they got one extra attempt. Channel errors now use the same bound.