Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: celery/kombu
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.2.1
Choose a base ref
...
head repository: celery/kombu
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.2.2
Choose a head ref
  • 4 commits
  • 7 files changed
  • 3 contributors

Commits on Dec 6, 2018

  1. Support redis-py v2 and v3 (#948) 

    Further to #946 this fixes the underlying issue in a easy-to-upgrade way
for end users, many of whom will have Redis installed via other means.
By having this check here and supporting both versions concurrently it
makes it easier for end users, and to use celery/kombu in projects that
use Redis elsewhere.

With this change it is possibly worth reverting #946
    @ashb @thedrow
    ashb authored and thedrow committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    94294a5 View commit details
    Browse the repository at this point in the history

  2. Correct order of Redis zadd dict elements (#953) 

    The changed `zadd()` behaviour in redis-py 3 states:
https://github.com/andymccurdy/redis-py#mset-msetnx-and-zadd

> For ZADD, the dict is a mapping of element-names -> score.

So the dictionary generated for `zadd()` should be flipped around to have the
`delivery_tag` as the key and the score as value. This commit fixes that.
    @Tenzer @thedrow
    Tenzer authored and thedrow committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    273b0f0 View commit details
    Browse the repository at this point in the history

  3. Update Changelog.

    @thedrow
    thedrow committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    2f4c377 View commit details
    Browse the repository at this point in the history

  4. Bump version: 4.2.1 → 4.2.2

    @thedrow
    thedrow committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    9a5d25e View commit details
    Browse the repository at this point in the history
Loading