CLI Refactor Design CEP#25
Merged
Merged
Conversation
auvipy
reviewed
Nov 29, 2019
auvipy
left a comment
auvipy
left a comment
Member
There was a problem hiding this comment.
looks good but will put more input tomorrow
Contributor
Author
|
How do we feel about using https://github.com/tiangolo/typer? |
Member
|
wow! we are thinking the same! check celery/celery#5718 (comment) |
Contributor
Author
|
Typer currently doesn't support async CLI commands. I've discussed with the maintainer how it might be done. Since celery/celery#5718 was merged this should be accepted. |
auvipy
approved these changes
Jan 4, 2021
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the Design CEP for celery/celery#5718.
Besides some missing links and a few touches it is done.
Who is going to shepherd this CEP?