Skip to content

Conversation

@woutdenolf
Copy link
Contributor

@woutdenolf woutdenolf commented Oct 3, 2022

@woutdenolf woutdenolf marked this pull request as draft October 3, 2022 09:52
@woutdenolf woutdenolf marked this pull request as ready for review October 3, 2022 10:01
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 89.60% // Head: 89.59% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (f77e98a) compared to base (88a0316).
Patch coverage: 57.14% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7785      +/-   ##
==========================================
- Coverage   89.60%   89.59%   -0.01%     
==========================================
  Files         128      128              
  Lines       15871    15877       +6     
  Branches     2116     2117       +1     
==========================================
+ Hits        14221    14225       +4     
- Misses       1421     1423       +2     
  Partials      229      229              
Flag Coverage Δ
unittests 89.57% <42.85%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
celery/utils/imports.py 88.29% <57.14%> (-1.48%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@woutdenolf woutdenolf mentioned this pull request Oct 3, 2022
@woutdenolf woutdenolf marked this pull request as draft October 3, 2022 10:24
@woutdenolf woutdenolf marked this pull request as ready for review October 3, 2022 10:35
@woutdenolf
Copy link
Contributor Author

Either this or #7782

@woutdenolf woutdenolf changed the title importlib_metadata removed deprecated entry point interfaces importlib_metadata remove deprecated entry point interfaces Oct 9, 2022
@auvipy auvipy added this to the 5.3 milestone Oct 12, 2022
@auvipy
Copy link
Member

auvipy commented Oct 19, 2022

with a new kombu release, the doc build is still failing, on python 3.7 first as per the doc build

@woutdenolf
Copy link
Contributor Author

woutdenolf commented Oct 19, 2022

The doc build installs kombu-5.2.4 not kombu-5.3.0b2

Collecting kombu<6.0,>=5.2.3
  Downloading kombu-5.2.4-py3-none-any.whl (189 kB)

dragondive added a commit to dragondive/askbot-devel that referenced this pull request Oct 13, 2025
…n 3.12

This commit makes the following changes to address deprecations and
removals in Python 3.12:

- Replace usage of `pkg_resources` with `importlib` as `pkg_resources`
  is deprecated and will be removed in December 2025. see: https://setuptools.pypa.io/en/stable/history.html#v80-9-0
- Upgrade `celery` to version `5.3.0` which includes fixes for the
  `entry_points` interface change in 3.12. This change was necessary to
  address unit test failures in 3.12. see: celery/celery#7785
- Replace `assertEquals` with `assertEqual` in unit tests as
  `assertEquals` has been removed in 3.12. see: https://docs.python.org/3.12/whatsnew/3.12.html#unittest-testcase-removed-aliases

This commit also includes the following changes as a consequence of
the above updates:
- Update `startup_procedures.py` to enable use of 3.12.
- In the `tests.yml` workflow, add 3.12 to the versions matrix.

In addition, this commit also makes the following change:
- Update `pre-commit/action` to the latest version `v3.0.1` to address
  the following runtime error with `v.2.0.0`: github.com/actions/cache/issues/820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Celery Import Error

3 participants