Reintroduce docstrings in programmatic start#6825
Merged
auvipy merged 1 commit intoJun 28, 2021
Merged
Conversation
* reintroduce sys.argv default behaviour for "start" (as was commented for "worker_main" in celery#6481 (comment) * reintroduce docstrings for "start" and "worker_main" methods * reintroduce and adapt tests for "start" and "worker_main" Programmatic start (code and unittests) was removed due to 01651d2 and reintroduced in celery#6481. Resolves: celery#6730 Relates: celery#6481 celery#6404
Codecov Report
@@ Coverage Diff @@
## master #6825 +/- ##
==========================================
+ Coverage 75.83% 79.15% +3.31%
==========================================
Files 138 138
Lines 16608 16610 +2
Branches 2096 2097 +1
==========================================
+ Hits 12595 13147 +552
+ Misses 3795 3236 -559
- Partials 218 227 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
This pull request introduces 1 alert and fixes 2 when merging a976655 into 117cd9c - view on LGTM.com new alerts:
fixed alerts:
|
maybe-sybr
approved these changes
Jun 28, 2021
maybe-sybr
left a comment
maybe-sybr
left a comment
Contributor
There was a problem hiding this comment.
lgtm - failing checks are likely the same ones which are busted on master right now. Happy for this to land in 5.1.x
auvipy
approved these changes
Jun 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
commented for "worker_main" in Restore app.start() and app.worker_main() #6481 (comment)
Programmatic start (code and unittests) was removed due to
01651d2 and reintroduced
in #6481.
Resolves: #6730
Relates: #6481 #6404