grp is no longer imported unconditionally#6804
Merged
Merged
Conversation
Contributor
Author
|
@voegtlel Could you please verify this patch works for you? |
Codecov Report
@@ Coverage Diff @@
## master #6804 +/- ##
=======================================
Coverage 70.69% 70.70%
=======================================
Files 138 138
Lines 16602 16603 +1
Branches 2091 2092 +1
=======================================
+ Hits 11737 11739 +2
+ Misses 4669 4668 -1
Partials 196 196
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Contributor
Author
|
The test doesn't seem to cover our new code branch. |
|
This pull request introduces 1 alert and fixes 1 when merging 03c58fe into 799f839 - view on LGTM.com new alerts:
fixed alerts:
|
maybe-sybr
suggested changes
Jun 7, 2021
Contributor
|
The change itself lgtm |
thedrow
force-pushed
the
fix-check-platform-on-nonunix
branch
from
June 8, 2021 13:29
e92bd07 to
6b31c52
Compare
|
This pull request introduces 1 alert and fixes 2 when merging 6b31c52 into 51634c3 - view on LGTM.com new alerts:
fixed alerts:
|
auvipy
approved these changes
Jun 8, 2021
maybe-sybr
approved these changes
Jun 9, 2021
Member
|
should be on 5.1.1 as it fixes a regression O:) |
maybe-sybr
added a commit
to mjhoffman65/celery
that referenced
this pull request
Jun 9, 2021
Also fix some flakes which may have been added by some other autoformatter in celery#6804. The 4 space non-visual-indentation should keep most formatters fairly happy.
maybe-sybr
added a commit
to mjhoffman65/celery
that referenced
this pull request
Jun 9, 2021
Also fix some flakes which may have been added by some other autoformatter in celery#6804. The 4 space non-visual-indentation should keep most formatters fairly happy.
maybe-sybr
added a commit
to mjhoffman65/celery
that referenced
this pull request
Jun 9, 2021
Also fix some flakes which may have been added by some other autoformatter in celery#6804. The 4 space non-visual-indentation should keep most formatters fairly happy.
thedrow
pushed a commit
that referenced
this pull request
Jun 27, 2021
* installs packages the same way docker does * removes couchbase dependency for PyPy * removes ephem dependency for PyPy * fixes mongo unit tests for PyPy3 Mocking `datetime.datetime` was causing an issue with `datetime.utcnow()`. This mock doesn't appear to be needed. See https://github.com/celery/celery/pull/6635/checks?check_run_id=1944166896. * fix: Avoid shadowing `Thread` attributes Fixes #6489 * ci: Install default deps for pypy3 toxenvs * ci: Run unit tests with `tox` * ci: Lint source in separate action using `tox` * ci: Redent codecov action * test: Rework some mocking in `test_platforms.py` Also fix some flakes which may have been added by some other autoformatter in #6804. The 4 space non-visual-indentation should keep most formatters fairly happy. * style: Fix some flakes Co-authored-by: maybe-sybr <[email protected]>
thedrow
added a commit
that referenced
this pull request
Jun 27, 2021
thedrow
pushed a commit
that referenced
this pull request
Jun 27, 2021
* installs packages the same way docker does * removes couchbase dependency for PyPy * removes ephem dependency for PyPy * fixes mongo unit tests for PyPy3 Mocking `datetime.datetime` was causing an issue with `datetime.utcnow()`. This mock doesn't appear to be needed. See https://github.com/celery/celery/pull/6635/checks?check_run_id=1944166896. * fix: Avoid shadowing `Thread` attributes Fixes #6489 * ci: Install default deps for pypy3 toxenvs * ci: Run unit tests with `tox` * ci: Lint source in separate action using `tox` * ci: Redent codecov action * test: Rework some mocking in `test_platforms.py` Also fix some flakes which may have been added by some other autoformatter in #6804. The 4 space non-visual-indentation should keep most formatters fairly happy. * style: Fix some flakes Co-authored-by: maybe-sybr <[email protected]>
jeyrce
pushed a commit
to jeyrce/celery
that referenced
this pull request
Aug 25, 2021
* grp is no longer imported unconditionally. This fixes a regression introduced in celery#6600 which caused an import error on non-unix platforms. Fixes celery#6797. * Adjust tests to cover the new code paths.
jeyrce
pushed a commit
to jeyrce/celery
that referenced
this pull request
Aug 25, 2021
* installs packages the same way docker does * removes couchbase dependency for PyPy * removes ephem dependency for PyPy * fixes mongo unit tests for PyPy3 Mocking `datetime.datetime` was causing an issue with `datetime.utcnow()`. This mock doesn't appear to be needed. See https://github.com/celery/celery/pull/6635/checks?check_run_id=1944166896. * fix: Avoid shadowing `Thread` attributes Fixes celery#6489 * ci: Install default deps for pypy3 toxenvs * ci: Run unit tests with `tox` * ci: Lint source in separate action using `tox` * ci: Redent codecov action * test: Rework some mocking in `test_platforms.py` Also fix some flakes which may have been added by some other autoformatter in celery#6804. The 4 space non-visual-indentation should keep most formatters fairly happy. * style: Fix some flakes Co-authored-by: maybe-sybr <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
This fixes a regression introduced in #6600 which caused an import error on non-Unix platforms.
Fixes #6797.