Skip to content

Support Redis Sentinel with SSL#6647

Merged
thedrow merged 1 commit into
masterfrom
revert-6518-revert-6490-ajk-sslsentinel
Feb 28, 2021
Merged

Support Redis Sentinel with SSL#6647
thedrow merged 1 commit into
masterfrom
revert-6518-revert-6490-ajk-sslsentinel

Conversation

@thedrow

@thedrow thedrow commented Feb 27, 2021

Copy link
Copy Markdown
Contributor

Reverts #6518.

We were going to release 5.0.6 which was a bugfix version which doesn't contain new features.
We have decided to go along with 5.1.0 immidiately instead.

See #6490 for the original pull request.

@thedrow thedrow added this to the 5.1.0 milestone Feb 27, 2021
@thedrow
thedrow requested a review from a team February 27, 2021 08:47
@thedrow thedrow linked an issue Feb 27, 2021 that may be closed by this pull request
18 tasks
@codecov

codecov Bot commented Feb 27, 2021

Copy link
Copy Markdown

Codecov Report

Merging #6647 (ff24414) into master (34c4697) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6647      +/-   ##
==========================================
- Coverage   70.42%   70.41%   -0.01%     
==========================================
  Files         138      138              
  Lines       16441    16446       +5     
  Branches     2063     2064       +1     
==========================================
+ Hits        11579    11581       +2     
- Misses       4660     4662       +2     
- Partials      202      203       +1     
Flag Coverage Δ
unittests 70.41% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
celery/backends/redis.py 83.28% <33.33%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34c4697...0747288. Read the comment docs.

@lgtm-com

lgtm-com Bot commented Feb 27, 2021

Copy link
Copy Markdown

This pull request introduces 1 alert and fixes 1 when merging 0747288 into 34c4697 - view on LGTM.com

new alerts:

  • 1 for Non-exception in 'except' clause

fixed alerts:

  • 1 for Unused import

@auvipy

auvipy commented Feb 27, 2021

Copy link
Copy Markdown
Member

thanks

@thedrow
thedrow merged commit 50ae433 into master Feb 28, 2021
@thedrow
thedrow deleted the revert-6518-revert-6490-ajk-sslsentinel branch February 28, 2021 09:14
jeyrce pushed a commit to jeyrce/celery that referenced this pull request Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sentinel with TLS not working

2 participants