Skip to content

Restore CLI plugins#6501

Merged
auvipy merged 2 commits into
masterfrom
cli-plugins
Nov 26, 2020
Merged

Restore CLI plugins#6501
auvipy merged 2 commits into
masterfrom
cli-plugins

Conversation

@thedrow

@thedrow thedrow commented Nov 25, 2020

Copy link
Copy Markdown
Contributor

Note: Before submitting this pull request, please review our contributing
guidelines.

Description

This PR fixes a regression in #5718 which overlooked the fact that we allow the CLI to be extended with new sub-command plugins.

I have also updated the documentation accordingly which fixes #6439.

@thedrow thedrow added this to the 5.0.3 milestone Nov 25, 2020
@lgtm-com

lgtm-com Bot commented Nov 25, 2020

Copy link
Copy Markdown

This pull request introduces 2 alerts when merging 727644f into dea0bd1 - view on LGTM.com

new alerts:

  • 1 for Non-exception in 'except' clause
  • 1 for Module is imported with 'import' and 'import from'

@codecov

codecov Bot commented Nov 25, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #6501 (727644f) into master (e203168) will increase coverage by 0.44%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6501      +/-   ##
==========================================
+ Coverage   75.50%   75.94%   +0.44%     
==========================================
  Files         138      138              
  Lines       16396    17108     +712     
  Branches     2059     2279     +220     
==========================================
+ Hits        12379    12993     +614     
- Misses       3795     3897     +102     
+ Partials      222      218       -4
Impacted Files Coverage Δ
celery/bin/celery.py 0.00% <0.00%> (ø)
celery/platforms.py 64.50% <0.00%> (-1.55%) ⬇️
celery/local.py 89.50% <0.00%> (+0.89%) ⬆️
celery/app/trace.py 98.63% <0.00%> (+0.93%) ⬆️
celery/backends/base.py 98.19% <0.00%> (+2.65%) ⬆️
celery/backends/cassandra.py 97.18% <0.00%> (+3.49%) ⬆️
celery/utils/imports.py 65.57% <0.00%> (+4.85%) ⬆️
celery/concurrency/thread.py 97.14% <0.00%> (+8.68%) ⬆️
celery/utils/collections.py 57.80% <0.00%> (+8.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e203168...727644f. Read the comment docs.

@thedrow
thedrow requested a review from a team November 25, 2020 15:42
@thedrow thedrow mentioned this pull request Nov 25, 2020
Closed
@auvipy
auvipy merged commit 07000d8 into master Nov 26, 2020
@auvipy auvipy mentioned this pull request Nov 26, 2020
Closed
4 tasks
@thedrow
thedrow deleted the cli-plugins branch November 26, 2020 07:54
JackBurdick added a commit to JackBurdick/sensorrunner that referenced this pull request Nov 27, 2020
@JackBurdick
Remove custom arg attempt until 5.0.3
445cd68 
Will wait until 5.0.3 https://github.com/celery/celery/milestone/32,  relevant: celery/celery#6501 and 
celery/celery#6307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@auvipy auvipy auvipy approved these changes

Assignees

No one assigned

Labels

Category: Documentation Component: CLI PR Type: Bugfix

Projects

None yet

Milestone

5.0.3

Development

Successfully merging this pull request may close these issues.

Adding new command-line options no longer works

2 participants

@thedrow @auvipy