Skip to content

redis: Support Sentinel with SSL#6490

Merged
auvipy merged 1 commit into
celery:masterfrom
AbdealiLoKo:ajk-sslsentinel
Dec 3, 2020
Merged

redis: Support Sentinel with SSL#6490
auvipy merged 1 commit into
celery:masterfrom
AbdealiLoKo:ajk-sslsentinel

Conversation

@auvipy

@auvipy auvipy commented Nov 19, 2020

Copy link
Copy Markdown
Member

Use the SentinelManagedSSLConnection when SSL is enabled for the
transport.

Note: Before submitting this pull request, please review our contributing
guidelines.

Description

@lgtm-com

lgtm-com Bot commented Nov 19, 2020

Copy link
Copy Markdown

This pull request fixes 1 alert when merging 914ef8b into 60ba379 - view on LGTM.com

fixed alerts:

  • 1 for Non-exception in 'except' clause

@AbdealiLoKo

AbdealiLoKo commented Nov 23, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

@auvipy Just saw that you created this - Thanks :)
I've modified the PR to create the SentinelManagedSSLConnection class directly in Celery for now - until redis/redis-py#1419 gets merged

This PR relates to: #6455

@lgtm-com

lgtm-com Bot commented Nov 23, 2020

Copy link
Copy Markdown

This pull request fixes 2 alerts when merging f59f853 into e203168 - view on LGTM.com

fixed alerts:

  • 1 for Non-exception in 'except' clause
  • 1 for Module is imported with 'import' and 'import from'

@auvipy

auvipy commented Nov 23, 2020

Copy link
Copy Markdown
Member Author

@auvipy Just saw that you created this - Thanks :)
I've modified the PR to create the SentinelManagedSSLConnection class directly in Celery for now - until andymccurdy/redis-py#1419 gets merged

This PR relates to: #6455

yup on behalf of you O:)

@auvipy auvipy added this to the 5.0.3 milestone Nov 23, 2020
@AbdealiLoKo
AbdealiLoKo force-pushed the ajk-sslsentinel branch 3 times, most recently from 84dadb6 to 7061ad6 Compare November 23, 2020 18:11
@lgtm-com

lgtm-com Bot commented Nov 23, 2020

Copy link
Copy Markdown

This pull request fixes 2 alerts when merging 7061ad6 into e203168 - view on LGTM.com

fixed alerts:

  • 1 for Non-exception in 'except' clause
  • 1 for Module is imported with 'import' and 'import from'

@AbdealiLoKo
redis: Support Sentinel with SSL
a86ed1b 
Use the SentinelManagedSSLConnection when SSL is enabled for the
transport. The redis-py project doesn't have a connection class for
SSL+Sentinel yet. So, create a class in redis.py to add that
functionality.
@AbdealiLoKo

AbdealiLoKo commented Dec 3, 2020

Copy link
Copy Markdown
Contributor

@auvipy Could we get this merged ?

@lgtm-com

lgtm-com Bot commented Dec 3, 2020

Copy link
Copy Markdown

This pull request fixes 2 alerts when merging a86ed1b into 1c076a6 - view on LGTM.com

fixed alerts:

  • 1 for Non-exception in 'except' clause
  • 1 for Module is imported with 'import' and 'import from'

@auvipy
auvipy merged commit 18a0963 into celery:master Dec 3, 2020
@thedrow

thedrow commented Dec 3, 2020

Copy link
Copy Markdown
Contributor

Wait this is a new feature. It requires a new Kombu release as well.
Master is currently at 5.0.3.
So what do we do here? Release 5.1?

@xirdneh

xirdneh commented Dec 3, 2020

Copy link
Copy Markdown
Member

If we need to do a new Kombu release and the work hasn't been done yet we cannot merge this

Also, we have to plan for new features. It would be nice to have it in prod right away but without consistency the project becomes less stable

@thedrow

thedrow commented Dec 3, 2020

Copy link
Copy Markdown
Contributor

@AbdealiJK After discussing this with @xirdneh, we decided to revert this as this belongs in 5.1.0.
We'll re-create this PR and merge it after we release 5.0.3.

@thedrow thedrow mentioned this pull request Dec 3, 2020
Merged
@auvipy auvipy modified the milestones: 5.0.3, 5.1.0 Feb 25, 2021
@auvipy

auvipy commented Feb 25, 2021

Copy link
Copy Markdown
Member Author

I missed this thread

@thedrow

thedrow commented Feb 27, 2021

Copy link
Copy Markdown
Contributor

Yeh we need to revert the revert.

@thedrow thedrow mentioned this pull request Feb 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Component: Redis Results Backend redis-py

Projects

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@auvipy @AbdealiLoKo @thedrow @xirdneh