Specify utf-8 as the encoding for log files.#6357
Merged
Merged
Conversation
Contributor
Author
|
@kyungSong @sihrc does this resolve your problem? |
|
This pull request fixes 1 alert when merging 1b30740 into 5a0c458 - view on LGTM.com fixed alerts:
|
|
I'll have to test and get back to you on this. I'll comment as soon as I find out if this fix works |
Member
|
did you check this? |
| if hasattr(logfile, 'write'): | ||
| return logging.StreamHandler(logfile) | ||
| return WatchedFileHandler(logfile) | ||
| return WatchedFileHandler(logfile, encoding='utf-8') |
Contributor
There was a problem hiding this comment.
Is this a problem for existing log files? Other than that it would seem to cover most use cases. Maybe in the future it could become a setting.
|
hey, sorry for the late response, work was slamming this week. Yes, this solved it! (was using redis as backend, celery version 4.1.1) Thanks a bunch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
Fixes #5144.