Skip to content

Expose retry_policy for Redis result backend#6330

Merged
auvipy merged 1 commit into
celery:masterfrom
ashb:redis-retry-policy
Sep 9, 2020
Merged

Expose retry_policy for Redis result backend#6330
auvipy merged 1 commit into
celery:masterfrom
ashb:redis-retry-policy

Conversation

@ashb

@ashb ashb commented Sep 2, 2020

Copy link
Copy Markdown
Contributor

Rather than adding a new top-level config option, I have used a new key
in the already existing setting result_backend_transport_options.

Fixes #6166

@ashb ashb mentioned this pull request Sep 2, 2020
Merged
@lgtm-com

lgtm-com Bot commented Sep 2, 2020

Copy link
Copy Markdown

This pull request fixes 1 alert when merging 5eb36e8 into 7ba1b46 - view on LGTM.com

fixed alerts:

  • 1 for Non-exception in 'except' clause

@ashb
ashb force-pushed the redis-retry-policy branch from 5eb36e8 to c8dd9cc Compare September 2, 2020 17:38
@lgtm-com

lgtm-com Bot commented Sep 2, 2020

Copy link
Copy Markdown

This pull request fixes 1 alert when merging c8dd9cc into 7ba1b46 - view on LGTM.com

fixed alerts:

  • 1 for Non-exception in 'except' clause

@ashb
ashb force-pushed the redis-retry-policy branch from c8dd9cc to d057e08 Compare September 2, 2020 19:14
@ashb

ashb commented Sep 2, 2020

Copy link
Copy Markdown
Contributor Author

Test failed due to an apt-get timeout (i.e. random failure)

@lgtm-com

lgtm-com Bot commented Sep 2, 2020

Copy link
Copy Markdown

This pull request introduces 1 alert and fixes 1 when merging d057e08 into 7ba1b46 - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 1 for Non-exception in 'except' clause

@ashb

ashb commented Sep 2, 2020

Copy link
Copy Markdown
Contributor Author

@auvipy PTAL/restart CI when you have a few spare cycles? Thanks.

@auvipy auvipy added this to the 5.0.0 milestone Sep 6, 2020
auvipy
auvipy reviewed Sep 6, 2020
View reviewed changes
Comment thread celery/backends/redis.py Outdated
@auvipy auvipy closed this Sep 6, 2020
@auvipy auvipy reopened this Sep 6, 2020
thedrow
thedrow suggested changes Sep 6, 2020
View reviewed changes
Comment thread celery/backends/redis.py Outdated
@ashb
ashb requested a review from thedrow September 8, 2020 14:56
@lgtm-com

lgtm-com Bot commented Sep 8, 2020

Copy link
Copy Markdown

This pull request introduces 1 alert when merging 7a365b3 into 465d267 - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

auvipy
auvipy reviewed Sep 9, 2020
View reviewed changes

@auvipy auvipy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the lint errors related?

@thedrow

thedrow commented Sep 9, 2020

Copy link
Copy Markdown
Contributor

are the lint errors related?

Yes they are.

thedrow
thedrow suggested changes Sep 9, 2020
View reviewed changes

@thedrow thedrow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the lint failures.

@ashb
ashb force-pushed the redis-retry-policy branch from 7a365b3 to 2a05c6f Compare September 9, 2020 09:14
@lgtm-com

lgtm-com Bot commented Sep 9, 2020

Copy link
Copy Markdown

This pull request introduces 1 alert when merging 2a05c6f into 465d267 - view on LGTM.com

new alerts:

  • 1 for Non-exception in 'except' clause

@ashb
Expose retry_policy for Redis result backend
f6198f5 
Rather than adding a new top-level config option, I have used a new key
in the already existing setting `result_backend_transport_options`.

Closes celery#6166
@ashb
ashb force-pushed the redis-retry-policy branch from 2a05c6f to f6198f5 Compare September 9, 2020 11:23
@lgtm-com

lgtm-com Bot commented Sep 9, 2020

Copy link
Copy Markdown

This pull request introduces 2 alerts when merging f6198f5 into 465d267 - view on LGTM.com

new alerts:

  • 1 for Non-exception in 'except' clause
  • 1 for Module is imported with 'import' and 'import from'

@ashb

ashb commented Sep 9, 2020

Copy link
Copy Markdown
Contributor Author

Travis/linted tests passing now.

@ashb
ashb requested a review from thedrow September 9, 2020 15:51
@auvipy
auvipy merged commit b08efaa into celery:master Sep 9, 2020
@ashb
ashb deleted the redis-retry-policy branch September 10, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@auvipy auvipy auvipy approved these changes
@thedrow thedrow Awaiting requested review from thedrow

Assignees

No one assigned

Labels

Component: Redis Results Backend PR Type: Enhancement

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

Expose config option to set retry_policy on (Redis) ResultBackend

3 participants

@ashb @thedrow @auvipy