Skip to content

issue 6108 fix filesystem backend cannot not be serialized by picked#6120

Merged
auvipy merged 3 commits into
celery:masterfrom
singlaive:issue-6108_filesystem_backend_pickle
May 30, 2020
Merged

issue 6108 fix filesystem backend cannot not be serialized by picked#6120
auvipy merged 3 commits into
celery:masterfrom
singlaive:issue-6108_filesystem_backend_pickle

Conversation

@singlaive

@singlaive singlaive commented May 27, 2020

Copy link
Copy Markdown
Contributor

#6108

Note: Before submitting this pull request, please review our contributing
guidelines.

Description

This PR is to fix issue-6108, that when a instance of FilesystemBackend class is pickled, it cannot be deserialised because a mandatory parameter has not been provided.

The unit test still needs further working, since the backend complains it needs a live app to be pickled.

@lgtm-com

lgtm-com Bot commented May 27, 2020

Copy link
Copy Markdown

This pull request introduces 1 alert when merging ade0ab2 into 704896a - view on LGTM.com

new alerts:

  • 1 for Modification of parameter with default

auvipy
auvipy requested changes May 27, 2020
View reviewed changes

@auvipy auvipy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit tests are failing

auvipy
auvipy reviewed May 30, 2020
View reviewed changes
Comment thread t/unit/backends/test_filesystem.py Outdated
@pytest.mark.usefixtures('depends_on_current_app')
def test_pickleable(self):
tb = FilesystemBackend(app=self.app, url=self.url, serializer='pickle')
assert pickle.loads(pickle.dumps(tb)) No newline at end of file

@auvipy auvipy May 30, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no new line

@auvipy auvipy May 30, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the flake8 error

@lgtm-com

lgtm-com Bot commented May 30, 2020

Copy link
Copy Markdown

This pull request introduces 2 alerts when merging db2f23d into 364bb29 - view on LGTM.com

new alerts:

  • 1 for Non-exception in 'except' clause
  • 1 for Modification of parameter with default

@lgtm-com

lgtm-com Bot commented May 30, 2020

Copy link
Copy Markdown

This pull request introduces 7 alerts when merging 8f37762 into 364bb29 - view on LGTM.com

new alerts:

  • 5 for Module is imported with 'import' and 'import from'
  • 1 for Non-exception in 'except' clause
  • 1 for Modification of parameter with default

@auvipy
auvipy merged commit ffc9f01 into celery:master May 30, 2020
@auvipy auvipy added this to the 4.4.x milestone May 30, 2020
auvipy added a commit that referenced this pull request Jul 8, 2020
@thedrow @verhovsky
@auvipy @jainal09 @gsfish @dipAch @spengjie @chris-griffin @mhewedy @phated @tamsanh @eriktews @anilaratna2 @wyguy444 @galCohen88 @alfred-sa @paramkpr @sveniu @safwanrahman Aissaoui Anouar @qdzzyb2014 @Alireza2n @marcosmoyano @shenek @AndrewPix @fladi @dejlek @yannickschuchmann @matteius @tirkarthi @bernd-wechner @soldag @uddmorningsun @marfgold1 @Wooden-Robot @imomaliev @AlexRiina @xncbf @nixphix @martey @Seleznev-nvkz @Prodge @adyouri @Ixiodor @abhishekakamai @allanlei @M1ha-Shvn @hicay @michamos @chrisburr @tildedave @the-owl Michael Gaddis @epwalsh @TalRoni @lpsinger @neonbunny Abhishek @theirix @yukihira1992 @jpays-cnp @gward Alexa Griffith @heedong-jung @heedongsamsung @shreyanshk @georgedorn @Alphadelta14 @azimjohn @ysde @amirzia @nadflinn @nezhar @specialorange @aeijdenberg rafaelreuber @coderanger @clems4ever Mathieu Chataigner @eugeneyalansky @leonardsocialcodeinc @xinydev @watercrossing @hanchau shaoziwei @mchataigner @Anakael @ckdanny @Tirzono @dtilloy-criteo @anthonynsimon @lironhl @Darkheir @Kirade @singlaive Murphy Meng @whtsky @kwist-sgr @ldragan @nijel @radimsuckr @art-vasilyev @kakakikikeke-fork @baixuexue123 baixue @prashnts @AbdealiLoKo