Skip to content

Use ubuntu bionic for python <= 3.6 in Travis#6096

Closed
mchataigner wants to merge 1 commit into
celery:masterfrom
criteo-forks:travis_ubuntu
Closed

Use ubuntu bionic for python <= 3.6 in Travis#6096
mchataigner wants to merge 1 commit into
celery:masterfrom
criteo-forks:travis_ubuntu

Conversation

@mchataigner

Copy link
Copy Markdown
Contributor

No description provided.

@auvipy

auvipy commented May 14, 2020

Copy link
Copy Markdown
Member

can you check here why python 2.7 is failing? #6095

@auvipy auvipy added this to the 4.4.x milestone May 14, 2020
@auvipy
auvipy self-requested a review May 14, 2020 14:34
@mchataigner

Copy link
Copy Markdown
Contributor Author

By curiosity, why do you keep python 2.7 as it's EOL since January, 1st 2020?

@auvipy

auvipy commented May 14, 2020

Copy link
Copy Markdown
Member

will drop it in celery 4.5

@auvipy

auvipy commented May 14, 2020

Copy link
Copy Markdown
Member

should we try xenial for python 2.7?

@mchataigner

Copy link
Copy Markdown
Contributor Author

Pytest > 4.6.x does not support python < 3.5
But here the problem is about wrong arguments passed to pytest.
Command specified for unit tests in tox.ini seems not compatible with python 2.7.
I don't know which version of pytest it's using though.

It was working with bionic and python 2.7 on this patch https://travis-ci.org/github/celery/celery/builds/667597080 so it's not related to distribution.

The first build with error on python 2.7 was https://travis-ci.org/github/celery/celery/builds/677296325

Comment thread .travis.yml
fast_finish: true
include:
- python: 2.7
stage: test

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stage is not needed

@auvipy

auvipy commented May 15, 2020

Copy link
Copy Markdown
Member

apparently this PR is not needed as only python 2.7 parsing command failing on master

@auvipy auvipy closed this May 15, 2020
@mchataigner
mchataigner deleted the travis_ubuntu branch June 3, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants