Update couchbase API to 3.0.0#6094
Closed
mchataigner wants to merge 1 commit into
Closed
Conversation
Member
|
thanks for handling this! |
Member
|
python 3.7 n 3.8 is passing the remaining r failing. can you check? |
Member
|
can you change the Travis Linux from focal to bionic to python 2.7, 3.5, and 3.6? |
Contributor
Author
|
done in a separate PR #6096 |
Contributor
Author
|
It seems couchbase python client 3.0.0+ has a requirement for python 3.7 on Windows. |
Member
|
lelts keep this for future version of celery |
Member
|
this should be rebased on master for celery v5 |
thedrow
suggested changes
Aug 25, 2020
Comment on lines
+21
to
+27
| # from couchbase.connection import Connection | ||
| # from couchbase.exceptions import NotFoundError | ||
| from couchbase_core._libcouchbase import FMT_AUTO | ||
| # from couchbase import FMT_AUTO | ||
| except ImportError: | ||
| Couchbase = Connection = NotFoundError = None # noqa | ||
| Cluster = PasswordAuthenticator = ClusterOptions = None | ||
| # Couchbase = Connection = NotFoundError = None # noqa |
Contributor
There was a problem hiding this comment.
Please do not leave commented out code in the codebase.
Contributor
|
Unfortunately you didn't allow edits from maintainers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tentative to update couchbase code to 3.0.0 API.
I will need a Couchbase specialist to validate this code.