Ensure a single chain object in a chain does not crash#6059
Merged
Conversation
Member
|
a unit test is failing |
…onError. Previously chain([chain(sig)]) would crash. We now ensure it doesn't. Fixes #5973.
thedrow
force-pushed
the
max-recursion-chain
branch
from
April 26, 2020 10:55
f53cf07 to
a0dbea1
Compare
Contributor
Author
|
The problem was in the test. I think this should fix it. |
auvipy
approved these changes
Apr 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
Previously
chain([chain(sig)])would crash.We now ensure it doesn't.
Fixes #5973.