Add internal_error signal#6027
Closed
ldragan wants to merge 1 commit into
Closed
Conversation
There is no special signal for an out of body error which can be the result of a bad result backend.
auvipy
requested changes
Apr 7, 2020
| return trace_ok_t(report_internal_error(task, exc), None, 0.0, None) | ||
|
|
||
|
|
||
| def _signal_internal_error(task, uuid, args, kwargs, request, exc): |
Member
There was a problem hiding this comment.
this need proper test coverage. and entry to changelog
Contributor
|
It's a shame you didn't use a different branch other than master. Please create a branch on your fork when contributing in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
There is no special signal for an out of body error which can be the
result of a bad result backend.
We want to add a new signal
task_internal_errorwhich will call the signal handler in case of an out of body error.