Clean TraceBack to reduce memory leaks for exception task#6024
Merged
Conversation
auvipy
requested changes
Apr 6, 2020
auvipy
left a comment
auvipy
left a comment
Member
There was a problem hiding this comment.
can you also add proper unit test?
Codecov Report
@@ Coverage Diff @@
## master #6024 +/- ##
==========================================
+ Coverage 83.42% 83.43% +<.01%
==========================================
Files 145 145
Lines 17186 17217 +31
Branches 2118 2126 +8
==========================================
+ Hits 14338 14365 +27
- Misses 2628 2630 +2
- Partials 220 222 +2
Continue to review full report at Codecov.
|
auvipy
requested changes
Apr 6, 2020
auvipy
left a comment
auvipy
left a comment
Member
There was a problem hiding this comment.
please check the python 2.7 failure and increase code coverage.
auvipy
requested changes
Apr 7, 2020
auvipy
approved these changes
Apr 7, 2020
18 tasks
asfaltboy
reviewed
May 9, 2020
thebarbershop
pushed a commit
to sendbird-graveyard/celery
that referenced
this pull request
Jul 1, 2020
* Clean TraceBack to reduce memory leaks * add unit test * add unit test * reject unittest * Patch For Python 2.7 compatibility * update unittest * Register to the garbage collector by explicitly referring to f_locals. * need more check * update code coverage * update Missing unit test * 3.4 -> 3.5 Co-authored-by: heedong.jung <[email protected]>
thebarbershop
pushed a commit
to sendbird-graveyard/celery
that referenced
this pull request
Jul 1, 2020
* Clean TraceBack to reduce memory leaks * add unit test * add unit test * reject unittest * Patch For Python 2.7 compatibility * update unittest * Register to the garbage collector by explicitly referring to f_locals. * need more check * update code coverage * update Missing unit test * 3.4 -> 3.5 Co-authored-by: heedong.jung <[email protected]>
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
Fixes: #6023
It seems that a frame leak is occurring in the use of the e value returned by 'Execption as e'. Del tb is not enough. So we clean up the traceback in the last part that can be explicit.