Make 'socket_keepalive' optional variable#6000
Merged
Merged
Conversation
This was referenced Mar 12, 2020
auvipy
requested changes
Mar 12, 2020
auvipy
left a comment
auvipy
left a comment
Member
There was a problem hiding this comment.
ateast unit tests needed to be updated and if possible integration tests
| socket_connect_timeout and float(socket_connect_timeout), | ||
| } | ||
|
|
||
| # absent in redis.connection.UnixDomainSocketConnection |
Member
There was a problem hiding this comment.
dont we need to update tests for this?
Contributor
Author
There was a problem hiding this comment.
Done, I've added a check of this case below
Codecov Report
@@ Coverage Diff @@
## master #6000 +/- ##
==========================================
- Coverage 83.43% 82.89% -0.54%
==========================================
Files 145 145
Lines 17179 17181 +2
Branches 2116 2117 +1
==========================================
- Hits 14334 14243 -91
- Misses 2626 2717 +91
- Partials 219 221 +2
Continue to review full report at Codecov.
|
auvipy
approved these changes
Mar 16, 2020
I propose make 'socket_keepalive' an optional variable to fix #5994.
Also, I've made changes in User Guide (fixed variable names and added
versionadded)