Fix chords with chained groups (#5947)#5984
Merged
Merged
Conversation
auvipy
requested changes
Mar 1, 2020
auvipy
left a comment
auvipy
left a comment
Member
There was a problem hiding this comment.
can't you add unit test for this?
Contributor
Author
|
Yes, I'll update this PR with a test soon. |
the-owl
force-pushed
the
chord-with-groups-fix
branch
from
March 1, 2020 19:31
53c7c9d to
dbf7ee8
Compare
Codecov Report
@@ Coverage Diff @@
## master #5984 +/- ##
==========================================
- Coverage 83.43% 83.42% -0.01%
==========================================
Files 145 145
Lines 17177 17179 +2
Branches 2115 2116 +1
==========================================
Hits 14332 14332
- Misses 2626 2627 +1
- Partials 219 220 +1
Continue to review full report at Codecov.
|
auvipy
approved these changes
Mar 2, 2020
This was referenced Sep 18, 2020
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5947