Skip to content

Use configured db schema also for sequences#5972

Merged
auvipy merged 1 commit into
celery:masterfrom
soldag:seq-schema
Feb 27, 2020
Merged

Use configured db schema also for sequences#5972
auvipy merged 1 commit into
celery:masterfrom
soldag:seq-schema

Conversation

@soldag

@soldag soldag commented Feb 27, 2020

Copy link
Copy Markdown
Contributor

The configured schema is currently not taken into account when defining sequence generators for id fields.

Followup of #5910

auvipy
auvipy requested changes Feb 27, 2020
View reviewed changes

@auvipy auvipy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add some tests as well to verify the changes?

@auvipy auvipy added this to the 4.4.x milestone Feb 27, 2020
@soldag

soldag commented Feb 27, 2020

Copy link
Copy Markdown
Contributor Author

@auvipy I already adapted the test_table_schema_config test case accordingly

@auvipy
auvipy merged commit c52105e into celery:master Feb 27, 2020
@auvipy

auvipy commented Feb 27, 2020

Copy link
Copy Markdown
Member

sorry for overlooking :p

@soldag
soldag deleted the seq-schema branch February 27, 2020 13:42
auvipy added a commit that referenced this pull request Jul 8, 2020
@thedrow @verhovsky
@auvipy @jainal09 @gsfish @dipAch @spengjie @chris-griffin @mhewedy @phated @tamsanh @eriktews @anilaratna2 @wyguy444 @galCohen88 @alfred-sa @paramkpr @sveniu @safwanrahman Aissaoui Anouar @qdzzyb2014 @Alireza2n @marcosmoyano @shenek @AndrewPix @fladi @dejlek @yannickschuchmann @matteius @tirkarthi @bernd-wechner @soldag @uddmorningsun @marfgold1 @Wooden-Robot @imomaliev @AlexRiina @xncbf @nixphix @martey @Seleznev-nvkz @Prodge @adyouri @Ixiodor @abhishekakamai @allanlei @M1ha-Shvn @hicay @michamos @chrisburr @tildedave @the-owl Michael Gaddis @epwalsh @TalRoni @lpsinger @neonbunny Abhishek @theirix @yukihira1992 @jpays-cnp @gward Alexa Griffith @heedong-jung @heedongsamsung @shreyanshk @georgedorn @Alphadelta14 @azimjohn @ysde @amirzia @nadflinn @nezhar @specialorange @aeijdenberg rafaelreuber @coderanger @clems4ever Mathieu Chataigner @eugeneyalansky @leonardsocialcodeinc @xinydev @watercrossing @hanchau shaoziwei @mchataigner @Anakael @ckdanny @Tirzono @dtilloy-criteo @anthonynsimon @lironhl @Darkheir @Kirade @singlaive Murphy Meng @whtsky @kwist-sgr @ldragan @nijel @radimsuckr @art-vasilyev @kakakikikeke-fork @baixuexue123 baixue @prashnts @AbdealiLoKo
Remove PY3 conditionals (#5954