Skip to content

Fix labels on Github issue templates.#5955

Merged
auvipy merged 1 commit into
celery:masterfrom
mobolic:fix-issue-template-labels
Feb 7, 2020
Merged

Fix labels on Github issue templates.#5955
auvipy merged 1 commit into
celery:masterfrom
mobolic:fix-issue-template-labels

Conversation

@martey

@martey martey commented Feb 4, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #5938, which broke most of the issue templates.

Currently, navigating to https://github.com/celery/celery/issues/new/choose now only displays the "Minor Version Release Checklist" template:

Screenshot from 2020-02-04 12-53-40

This pull request escapes the labels in the template files (so that their colons don't cause the template to break) and changes the "Documentation Bug Report" template to only use one label (since using multiple escaped labels also breaks the template).

@martey
Fix labels on Github issue templates.
e754595 
Use quotation marks to escape labels on Github issue templates. This
prevents the colon from breaking the template.
@martey
martey force-pushed the fix-issue-template-labels branch from 0900ecc to e754595 Compare February 4, 2020 18:43
@martey

martey commented Feb 4, 2020

Copy link
Copy Markdown
Contributor Author

I've pushed a new commit which fixes the issue with the Documentation Bug Report's template multiple labels.

@thedrow

thedrow commented Feb 5, 2020

Copy link
Copy Markdown
Contributor

So that was the problem!
Their documentation is very unclear about that point.

@martey
martey requested a review from auvipy February 6, 2020 16:33
@martey martey mentioned this pull request Feb 6, 2020
Closed
@auvipy
auvipy merged commit 606307d into celery:master Feb 7, 2020
@auvipy auvipy added this to the 4.4.x milestone Feb 7, 2020
@auvipy auvipy linked an issue Feb 8, 2020 that may be closed by this pull request
How do I open a normal issue for celery ? #5957
Closed
auvipy added a commit that referenced this pull request Jul 8, 2020
@thedrow @verhovsky
@auvipy @jainal09 @gsfish @dipAch @spengjie @chris-griffin @mhewedy @phated @tamsanh @eriktews @anilaratna2 @wyguy444 @galCohen88 @alfred-sa @paramkpr @sveniu @safwanrahman Aissaoui Anouar @qdzzyb2014 @Alireza2n @marcosmoyano @shenek @AndrewPix @fladi @dejlek @yannickschuchmann @matteius @tirkarthi @bernd-wechner @soldag @uddmorningsun @marfgold1 @Wooden-Robot @imomaliev @AlexRiina @xncbf @nixphix @martey @Seleznev-nvkz @Prodge @adyouri @Ixiodor @abhishekakamai @allanlei @M1ha-Shvn @hicay @michamos @chrisburr @tildedave @the-owl Michael Gaddis @epwalsh @TalRoni @lpsinger @neonbunny Abhishek @theirix @yukihira1992 @jpays-cnp @gward Alexa Griffith @heedong-jung @heedongsamsung @shreyanshk @georgedorn @Alphadelta14 @azimjohn @ysde @amirzia @nadflinn @nezhar @specialorange @aeijdenberg rafaelreuber @coderanger @clems4ever Mathieu Chataigner @eugeneyalansky @leonardsocialcodeinc @xinydev @watercrossing @hanchau shaoziwei @mchataigner @Anakael @ckdanny @Tirzono @dtilloy-criteo @anthonynsimon @lironhl @Darkheir @Kirade @singlaive Murphy Meng @whtsky @kwist-sgr @ldragan @nijel @radimsuckr @art-vasilyev @kakakikikeke-fork @baixuexue123 baixue @prashnts @AbdealiLoKo
Remove PY3 conditionals (#5954