Pass interval to get_many#5931
Conversation
|
File "/home/travis/build/celery/celery/celery/result.py", line 839 SyntaxError: invalid syntax |
auvipy
left a comment
auvipy
left a comment
There was a problem hiding this comment.
fix the unit test failures on python 2.7
| return self.result_consumer._wait_for_pending( | ||
| result, timeout=timeout, | ||
| on_interval=on_interval, on_message=on_message, | ||
| **kwargs, |
There was a problem hiding this comment.
Do we have test to cover the kwargs param?
There was a problem hiding this comment.
I can't seem to find any existing tests for kwargs for AsyncBackendMixin._wait_for_pending, but BaseResultConsumer._wait_for_pending supports kwargs (which also doesn't seem to have tests)
Codecov Report
@@ Coverage Diff @@
## master #5931 +/- ##
=======================================
Coverage 83.21% 83.21%
=======================================
Files 145 145
Lines 17130 17130
Branches 2110 2110
=======================================
Hits 14254 14254
Misses 2661 2661
Partials 215 215
Continue to review full report at Codecov.
|
|
Updated for py2.7 |
|
celery/backends/rpc.py:20: in E File "/home/travis/build/celery/celery/celery/backends/asynchronous.py", line 203 E **kwargs, E ^ E SyntaxError: invalid syntax |
|
Updated for py2.7 sytnax |
|
The build failure is due to a job being stuck for some reason. |
0194a92 to
9e09e84
Compare
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
kwargsis not passed to_iter_meta,_wait_for_pending. Due to this, options likeintervalare ignored.Fixes #5930