Skip to content

merge in place the apps beat schedule in the default Schedule class.#5908

Merged
auvipy merged 1 commit into
celery:masterfrom
matteius:issue-3862-default-beat-scheduler
Feb 28, 2020
Merged

merge in place the apps beat schedule in the default Schedule class.#5908
auvipy merged 1 commit into
celery:masterfrom
matteius:issue-3862-default-beat-scheduler

Conversation

@matteius

@matteius matteius commented Jan 7, 2020

Copy link
Copy Markdown
Contributor

This change was recommended in #3862 and the issue came up again recently. I checked the code that was referenced and sure enough, merging in the app's schedule only happens in the PersistentScheduler, hence this change.

auvipy
auvipy requested changes Jan 7, 2020
View reviewed changes

@auvipy auvipy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add tests for this as well?

auvipy
auvipy approved these changes Feb 28, 2020
View reviewed changes

@auvipy auvipy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@auvipy auvipy added this to the 4.4.x milestone Feb 28, 2020
@auvipy
auvipy merged commit fe0c33c into celery:master Feb 28, 2020
auvipy added a commit that referenced this pull request Jul 8, 2020
@thedrow @verhovsky
@auvipy @jainal09 @gsfish @dipAch @spengjie @chris-griffin @mhewedy @phated @tamsanh @eriktews @anilaratna2 @wyguy444 @galCohen88 @alfred-sa @paramkpr @sveniu @safwanrahman Aissaoui Anouar @qdzzyb2014 @Alireza2n @marcosmoyano @shenek @AndrewPix @fladi @dejlek @yannickschuchmann @matteius @tirkarthi @bernd-wechner @soldag @uddmorningsun @marfgold1 @Wooden-Robot @imomaliev @AlexRiina @xncbf @nixphix @martey @Seleznev-nvkz @Prodge @adyouri @Ixiodor @abhishekakamai @allanlei @M1ha-Shvn @hicay @michamos @chrisburr @tildedave @the-owl Michael Gaddis @epwalsh @TalRoni @lpsinger @neonbunny Abhishek @theirix @yukihira1992 @jpays-cnp @gward Alexa Griffith @heedong-jung @heedongsamsung @shreyanshk @georgedorn @Alphadelta14 @azimjohn @ysde @amirzia @nadflinn @nezhar @specialorange @aeijdenberg rafaelreuber @coderanger @clems4ever Mathieu Chataigner @eugeneyalansky @leonardsocialcodeinc @xinydev @watercrossing @hanchau shaoziwei @mchataigner @Anakael @ckdanny @Tirzono @dtilloy-criteo @anthonynsimon @lironhl @Darkheir @Kirade @singlaive Murphy Meng @whtsky @kwist-sgr @ldragan @nijel @radimsuckr @art-vasilyev @kakakikikeke-fork @baixuexue123 baixue @prashnts @AbdealiLoKo
Remove PY3 conditionals (#5954