Skip to content

whatsnew in Celery 4.4 as per projects standard#5817

Merged
auvipy merged 15 commits into
masterfrom
new
Dec 16, 2019
Merged

whatsnew in Celery 4.4 as per projects standard#5817
auvipy merged 15 commits into
masterfrom
new

Conversation

@auvipy

@auvipy auvipy commented Nov 6, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

to be completed before 14 november

@auvipy auvipy added this to the 4.4.0 milestone Nov 6, 2019
@auvipy auvipy self-assigned this Nov 6, 2019
@codecov

codecov Bot commented Nov 6, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #5817 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5817      +/-   ##
==========================================
+ Coverage   83.19%   83.28%   +0.09%     
==========================================
  Files         145      145              
  Lines       17128    17431     +303     
  Branches     2110     2204      +94     
==========================================
+ Hits        14249    14518     +269     
- Misses       2663     2698      +35     
+ Partials      216      215       -1
Impacted Files Coverage Δ
celery/bin/celery.py 97.72% <0%> (-0.33%) ⬇️
celery/utils/log.py 51.9% <0%> (-0.16%) ⬇️
celery/utils/__init__.py 0% <0%> (ø) ⬆️
celery/concurrency/thread.py 89.65% <0%> (+0.36%) ⬆️
celery/backends/dynamodb.py 98.18% <0%> (+0.39%) ⬆️
celery/backends/redis.py 93.75% <0%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b68aa04...eec71b4. Read the comment docs.

thedrow
thedrow suggested changes Nov 6, 2019
View reviewed changes

@thedrow thedrow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of this seems copy/pasted from the previous release.
Let's go over the release notes and check what really has changed.

Comment thread docs/whatsnew-4.4.rst Outdated
Comment thread docs/whatsnew-4.4.rst Outdated
Redis Message Broker
--------------------

Due to multiple bugs in earlier versions of py-redis that were causing

@thedrow thedrow Nov 6, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably mention the healthcheck changes and alert users that they should configure it.

@adw1n adw1n Nov 14, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

py-redis -> redis-py

Comment thread docs/whatsnew-4.4.rst Outdated
Comment thread docs/whatsnew-4.4.rst Outdated
Comment thread docs/whatsnew-4.4.rst Outdated
Comment thread docs/whatsnew-4.4.rst Outdated
thedrow
thedrow reviewed Nov 6, 2019
View reviewed changes
Comment thread docs/whatsnew-4.4.rst
thedrow
thedrow reviewed Nov 6, 2019
View reviewed changes
Comment thread docs/whatsnew-4.4.rst Outdated
thedrow
thedrow reviewed Nov 6, 2019
View reviewed changes
Comment thread docs/whatsnew-4.4.rst Outdated
thedrow
thedrow reviewed Nov 6, 2019
View reviewed changes
Comment thread docs/whatsnew-4.4.rst Outdated
thedrow
thedrow reviewed Nov 6, 2019
View reviewed changes
Comment thread docs/whatsnew-4.4.rst Outdated
@auvipy

auvipy commented Nov 6, 2019

Copy link
Copy Markdown
Member Author

thanks for the quick review! but it's not yet ready for review :D I went trough the actual release commit history and going to add them one by on thoroughly in next 1 week before the final release. This is he higest prio formeright now :D

@thedrow
thedrow changed the base branch from master to 4.4 November 6, 2019 12:20
@thedrow

thedrow commented Nov 6, 2019

Copy link
Copy Markdown
Contributor

thanks for the quick review! but it's not yet ready for review :D I went trough the actual release commit history and going to add them one by on thoroughly in next 1 week before the final release. This is he higest prio formeright now :D

I'll help :)

@auvipy

auvipy commented Nov 6, 2019

Copy link
Copy Markdown
Member Author

thanks for the quick review! but it's not yet ready for review :D I went trough the actual release commit history and going to add them one by on thoroughly in next 1 week before the final release. This is he higest prio formeright now :D

I'll help :)

that would be awesome. 4.4 seems appropriate! thanks!

@auvipy auvipy mentioned this pull request Dec 3, 2019
Closed
5 tasks
@auvipy
auvipy changed the base branch from 4.4 to master December 5, 2019 06:50
@thedrow

thedrow commented Dec 15, 2019

Copy link
Copy Markdown
Contributor

Actually the previous version already bumped our Django version to 1.11 if I remember correctly...

@auvipy

auvipy commented Dec 15, 2019

Copy link
Copy Markdown
Member Author

you are right

@auvipy
auvipy marked this pull request as ready for review December 16, 2019 02:10
@auvipy
auvipy merged commit 5fe4ea8 into master Dec 16, 2019
@thedrow

thedrow commented Dec 16, 2019

Copy link
Copy Markdown
Contributor

I'm right and you merged this anyway???? 😠

@AndrewPix

AndrewPix commented Dec 16, 2019

Copy link
Copy Markdown
Contributor

@thedrow Hey, as I can see from this commit eb37595
django version was bumped starting from 4.4.0rc1 tag

@AndrewPix

AndrewPix commented Dec 16, 2019

Copy link
Copy Markdown
Contributor

Aww, no, you are right, it was merged to 4.3 version already

@auvipy
auvipy deleted the new branch December 16, 2019 10:07
auvipy added a commit that referenced this pull request Feb 26, 2020
@thedrow @nijel
@ptitpoulpe Didi Bar-Zev @santos22 @manlix Jimmy @verhovsky @auvipy @jainal09 @gsfish @dipAch @spengjie @chris-griffin @mhewedy @phated @tamsanh @eriktews @anilaratna2 @wyguy444 @galCohen88 @alfred-sa @paramkpr @sveniu @safwanrahman Aissaoui Anouar @qdzzyb2014 @Alireza2n @marcosmoyano @shenek @AndrewPix @fladi @dejlek @yannickschuchmann @matteius @tirkarthi @bernd-wechner @soldag @uddmorningsun @marfgold1 @Wooden-Robot @imomaliev