Fix test_group_result_not_has_cache for sync backends with native join#5744
Merged
thedrow merged 1 commit intoOct 24, 2019
Merged
Conversation
thedrow
force-pushed
the
fix-test_group_result_not_has_cache-for-cache-backend
branch
from
September 23, 2019 16:01
b65d976 to
6a7b922
Compare
Contributor
Author
|
Lets hold until we can figure out all the problems in #5739. |
auvipy
approved these changes
Sep 23, 2019
Contributor
Author
|
/rebase |
Contributor
Author
|
No more rebase bot? :( |
thedrow
force-pushed
the
fix-test_group_result_not_has_cache-for-cache-backend
branch
from
October 24, 2019 11:27
562a0dc to
d51544b
Compare
Codecov Report
@@ Coverage Diff @@
## master #5744 +/- ##
=========================================
- Coverage 83.39% 83.29% -0.1%
=========================================
Files 144 144
Lines 16702 16712 +10
Branches 2080 2083 +3
=========================================
- Hits 13928 13921 -7
- Misses 2560 2574 +14
- Partials 214 217 +3
Continue to review full report at Codecov.
|
thedrow
deleted the
fix-test_group_result_not_has_cache-for-cache-backend
branch
October 24, 2019 11:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
PR #5739 uncovered multiple problems with the cache backend.
This PR should resolve one of them.
PR #5638 fixed the same test case for our async results backends that support native join.
However, it did not fix the test case for sync results backends that support native join.
Unfortunately the fix provided here is inelegant at best.Further suggestions are welcome.
The provided fix simply fetches the results from
ResultSets first.Afterwards, it batches the fetching of all the results from tasks.