Conversation
|
looks really interesting!!! |
|
pyupgrade is very conservative in transforming strings into format strings. |
Codecov Report
@@ Coverage Diff @@
## v5-dev #5726 +/- ##
=========================================
Coverage ? 83.06%
=========================================
Files ? 144
Lines ? 16394
Branches ? 2048
=========================================
Hits ? 13618
Misses ? 2558
Partials ? 218
Continue to review full report at Codecov.
|
georgepsarakis
left a comment
georgepsarakis
left a comment
There was a problem hiding this comment.
Seems quite accurate, nice work indeed.
| try: | ||
| conn = app.connection() | ||
| driver_v = '{0}:{1}'.format(conn.transport.driver_name, | ||
| driver_v = '{}:{}'.format(conn.transport.driver_name, |
There was a problem hiding this comment.
I think now the indentation on line 343 is wrong.
|
@auvipy Should we merge this? |
auvipy
left a comment
auvipy
left a comment
There was a problem hiding this comment.
sorry, my reveiw wasn't complete.
thedrow
left a comment
thedrow
left a comment
There was a problem hiding this comment.
Please review again.
|
good job. just one suggestion, you could pull from master here, this will keep the v5 PR clean from merge from the master. |
|
t/unit/apps/test_multi.py:8: in E File "/home/travis/build/celery/celery/celery/apps/multi.py", line 130 E self.cmd = cmd or f'-m {celery_exe('worker', '--detach')}' E ^ E SyntaxError: invalid syntax |
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
pyupgrade is an automatic tool that upgrades codebases to Python 3.
I think it did the trick pretty well.
The unit tests pass so that's something.