Skip to content

Fix canvases which used to raise an exception whenever subsequent groups are chained one after another#5682

Merged
auvipy merged 2 commits into
masterfrom
fix-task-group-group-task-canvas
Aug 19, 2019
Merged

Fix canvases which used to raise an exception whenever subsequent groups are chained one after another#5682
auvipy merged 2 commits into
masterfrom
fix-task-group-group-task-canvas

Conversation

@thedrow

@thedrow thedrow commented Aug 19, 2019

Copy link
Copy Markdown
Contributor

Fix canvases which used to raise an exception whenever subsequent groups are chained one after another and are automatically converted into a chord.

Fixes #5467, fixes #3585.

…ups are chained one after another and are automatically converted into a chord.

Fixes #5467, fixes #3585.
@thedrow thedrow changed the title *Note*: Before submitting this pull request, please review our [contributing guidelines](https://docs.celeryproject.org/en/master/contributing.html). ## Description Fix canvases which used to raise an exception whenever subsequent groups are chained one after another Aug 19, 2019
@thedrow thedrow added this to the 4.4.0 milestone Aug 19, 2019
Comment thread celery/canvas.py Outdated
@codecov

codecov Bot commented Aug 19, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5682 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5682      +/-   ##
==========================================
- Coverage   83.36%   83.35%   -0.02%     
==========================================
  Files         144      144              
  Lines       16683    16686       +3     
  Branches     2074     2074              
==========================================
  Hits        13908    13908              
- Misses       2559     2562       +3     
  Partials      216      216
Impacted Files Coverage Δ
celery/canvas.py 93.45% <0%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89c4573...fec443e. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Aug 19, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5682 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5682      +/-   ##
==========================================
- Coverage   83.36%   83.35%   -0.02%     
==========================================
  Files         144      144              
  Lines       16683    16686       +3     
  Branches     2074     2074              
==========================================
  Hits        13908    13908              
- Misses       2559     2562       +3     
  Partials      216      216
Impacted Files Coverage Δ
celery/canvas.py 93.45% <0%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89c4573...fec443e. Read the comment docs.

@auvipy
auvipy merged commit 8f697de into master Aug 19, 2019
@thedrow
thedrow deleted the fix-task-group-group-task-canvas branch August 19, 2019 19:13
jeyrce pushed a commit to jeyrce/celery that referenced this pull request Aug 25, 2021
…ups are chained one after another (celery#5682)

* Fix canvases which used to raise an exception whenever subsequent groups are chained one after another and are automatically converted into a chord.

Fixes celery#5467, fixes celery#3585.

* Fix typo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

task/group chains fails in some scenarios Subsequent groups within a chain fail

3 participants