[Fix #5436] Store extending result in all backends#5661
Conversation
|
What about backends such as MongoDB which override |
I have changed the mongodb one also! |
|
It shouldn't be hard to add the same capability to the Cassandra backend. |
georgepsarakis
left a comment
There was a problem hiding this comment.
Nice work, seems like a good improvement! There are several failures in unit tests that seem directly related to the changes, let me know if you need help resolving those.
|
Thanks @geoffreybauduin. I am trying to run the test locally to fix the tests actually! |
|
@sckhg1367 MongoDB is supported, probably the documentation needs to be updated: Would you like to open a PR perhaps to include all available result stores? |
|
Thanks @geoffreybauduin. |
|
Any updates on this? This is a crucial fix and looks like we are pretty close here. Can someone please prioritize this? |
|
I'll work on it. |
|
Sorry I could not get time to work on this! @thedrow Can you let me know what do you think about failing tests? |
|
I'll rebase first and then let you know. |
|
Great thanks guys for taking a look into this. |
|
I'm not sure I resolved the conflict correctly which is why I merged. |
|
seems only 1 failure |
|
@thedrow I think rebase is appropiate here. I will rebase it upon master and will take a look at the test failure. |
|
Any updates here? Can someone please share the estimated timeline for releasing Milestone |
|
30th Nov |
b414f7e to
1fea0ec
Compare
|
@auvipy Which tests you are referring? |
|
https://github.com/celery/celery/tree/master/t/unit/backends test_base, test_database, test_mongo |
| def is_cached(self, task_id): | ||
| return task_id in self._cache | ||
|
|
||
| def _get_result_meta(self, result, |
There was a problem hiding this comment.
particularly this block and related changes tests
|
@safwanrahman Are you working on the tests? I haven't contributed to this project before but I could try to help if you need any. Please let me know if we can still make it to the Milestone |
you can push some tests on his forks branch :) |
|
@auvipy @safwanrahman While I am touching this branch, just thought of checking with you guys if it would make sense to create a |
@safwanrahman @auvipy I few tests that I would like to push but I don't have permissions to push to your fork. Please let me know how you would like me this few changes. I will be out for the week so just created the PR to your branch here, please feel free to update if you would like to proceed meanwhile. Thanks. |
|
@akshjain83 Thanks for the commit, sorry I did not get time to write the tests myself. I have cherry-picked the commit and pushed to the branch. |
|
No worries @safwanrahman Happy to contribute. @auvipy How does the timeline looks like for milestone |
|
I'm hoping to make a release by the weekend. |
|
Thanks @thedrow |

This fixes #5436 except
cassendra. I do not have any experience with cassendra, so dont know how to fix that.