Use 'property' with 'abstractmethod' instead 'abstractproperty'#5456
Merged
Conversation
Contributor
|
What about 2.7? |
Contributor
Author
|
You are right, Python 2.7 can not use 'property' with 'abstractmethod'.
|
Member
wait for c5 |
Codecov Report
@@ Coverage Diff @@
## v5-dev #5456 +/- ##
==========================================
- Coverage 83.26% 82.79% -0.47%
==========================================
Files 144 144
Lines 16523 16491 -32
Branches 2096 2057 -39
==========================================
- Hits 13758 13654 -104
- Misses 2549 2625 +76
+ Partials 216 212 -4
Continue to review full report at Codecov.
|
Contributor
|
I've rebased this to be merged on Celery 5. |
Member
|
great |
Member
|
should we modify some tests to avoid any regression? |
Contributor
|
Which tests do you have in mind? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'@abc.abstractproperty' has deprecated since Python 3.3
It is now possible to use property, property.getter(), property.setter() and property.deleter() with abstractmethod(), making this decorator redundant.
Python doc