Issue #5436#5441
Closed
mrkcmo wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
@auvipy Please feel free to highly scrutinize my updates as this is my first PR for Celery and I want to make sure I didn't miss any layers. Thanks! |
Member
|
sure thanks for the pr |
Contributor
Author
|
@auvipy are there known issues with the build checks? I see them failing but not for issues with the code changes I submitted in the PR. |
Member
|
yes, ignore them for now, we are going to fix them soon. |
Contributor
|
@mrkcmo can you please rebase? i did some PR to solve CI for travis at least. |
Contributor
Author
I will try and do this shortly. |
Contributor
Author
|
I am going to close this one and submit a new one rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
The following fix is related to Issue #5436 in which the default result DB (SQLAlchemy) was not storing additional meta data in the result DB when the key result_extended was set to "True". The only DB that worked was the REDIS backend in which the original request for extended meta data was requested. This PR does not address a fix for the Mongo or other DB backends but just addresses the SQLAlchemy backend.
Fixes #5436