Update time.py to solve the microsecond issues#5199
Merged
Conversation
added 2 commits
November 27, 2018 16:02
When `relative` is set to True, the day, hour, minutes second will be round to the nearest one, however, the original program do not update the microsecond (reset it). As a result, the run-time offset on the microsecond will then be accumulated. For example, given the interval is 15s and relative is set to True 1. 2018-11-27T15:01:30.123236+08:00 2. 2018-11-27T15:01:45.372687+08:00 3. 2018-11-27T15:02:00.712601+08:00 4. 2018-11-27T15:02:15.987720+08:00 5. 2018-11-27T15:02:31.023670+08:00
Update time.py to solve the microsecond issues
auvipy
requested changes
Nov 27, 2018
auvipy
left a comment
auvipy
left a comment
Member
There was a problem hiding this comment.
could you add some test for this change?
georgepsarakis
approved these changes
Nov 27, 2018
thedrow
added
Status: Needs Test Coverage ✘
and removed
Status: Needs Testcase ✘
labels
auvipy
requested changes
May 6, 2019
auvipy
left a comment
auvipy
left a comment
Member
There was a problem hiding this comment.
could you please rebase it once on top of the master?
Codecov Report
@@ Coverage Diff @@
## master #5199 +/- ##
=======================================
Coverage 82.92% 82.92%
=======================================
Files 142 142
Lines 16165 16165
Branches 2019 2019
=======================================
Hits 13405 13405
Misses 2563 2563
Partials 197 197
Continue to review full report at Codecov.
|
|
This pull request fixes 5 alerts when merging 55e1de5 into fae3336 - view on LGTM.com fixed alerts:
|
auvipy
approved these changes
May 18, 2020
When
relativeis set to True, the day, hour, minutes second will be round to the nearest one, however, the original program do not update the microsecond (reset it). As a result, the run-time offset on the microsecond will then be accumulated.For example, given the interval is 15s and relative is set to True
When relative is set to True, microsecond offset still accumulate #5198