Added proper error messages in cases where app cannot be loaded#4990
Merged
Conversation
Previously we'd simply crash with an exception. Now a proper error message is displayed.
Codecov Report
@@ Coverage Diff @@
## master #4990 +/- ##
==========================================
+ Coverage 82.86% 82.88% +0.01%
==========================================
Files 140 140
Lines 15993 16003 +10
Branches 2003 2004 +1
==========================================
+ Hits 13253 13264 +11
+ Misses 2542 2541 -1
Partials 198 198
Continue to review full report at Codecov.
|
Member
|
I remember there is a related issue |
Member
|
should we get this in? |
Contributor
Author
|
I was waiting for a code review. |
auvipy
self-requested a review
November 19, 2018 13:12
Contributor
Author
|
@auvipy Ping? |
Member
|
please wait till tomorrow! I am quite busy today. sorry! |
auvipy
approved these changes
Jan 29, 2019
2 tasks
jeyrce
pushed a commit
to jeyrce/celery
that referenced
this pull request
Aug 25, 2021
…ery#4990) Previously we'd simply crash with an exception. Now a proper error message is displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we'd simply crash with an exception.
Now a proper error message is displayed.