Fixed sphinx-build check in Makefile#4728
Merged
auvipy merged 1 commit intocelery:masterfrom May 11, 2018
Merged
Conversation
If sphinx-build is not installed, the Makefile returns the cryptic 'recipe commences before first target. Stop.' when building the docs. The cause is a tab resulting in a syntax error. This was a bug in the Makefile generated by Sphinx, which has since been fixed: sphinx-doc/sphinx#2521 I've applied the same fix, which is removing the 'user-friendly' message. The resulting error message is 'sphinx-build: Command not found', which ought to be clear enough.
Codecov Report
@@ Coverage Diff @@
## master #4728 +/- ##
=========================================
Coverage ? 82.77%
=========================================
Files ? 140
Lines ? 15927
Branches ? 1995
=========================================
Hits ? 13183
Misses ? 2546
Partials ? 198Continue to review full report at Codecov.
|
auvipy
approved these changes
May 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If sphinx-build is not installed, the Makefile returns the cryptic 'recipe commences before first target. Stop.' when building the docs. The cause is a tab resulting in a syntax error. This was a bug in the
Makefile generated by Sphinx, which has since been fixed: sphinx-doc/sphinx#2521
I've applied the same fix, which is removing the 'user-friendly' message. The resulting error message is 'sphinx-build: Command not found', which ought to be clear enough.