fix: show user-friendly broker errors for remote CLI commands#10118
Closed
harshang03 wants to merge 2 commits into
Closed
fix: show user-friendly broker errors for remote CLI commands#10118harshang03 wants to merge 2 commits into
harshang03 wants to merge 2 commits into
Conversation
Convert broker connection failures in `status` into concise actionable CLI errors instead of tracebacks, and apply the same error handling path to related remote CLI flows. Add regression coverage for broker-unreachable and unexpected-error handling in status/graph/events command paths.
auvipy
self-requested a review
February 14, 2026 07:37
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10118 +/- ##
==========================================
- Coverage 87.77% 87.77% -0.01%
==========================================
Files 153 153
Lines 19417 19438 +21
Branches 2231 2233 +2
==========================================
+ Hits 17044 17062 +18
Misses 2076 2076
- Partials 297 300 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
auvipy
requested changes
Mar 2, 2026
auvipy
left a comment
Member
There was a problem hiding this comment.
can you please improve the test coverage?
3 tasks
Member
|
superseded by #10190 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
status,inspect,control,graph workers, andeventscommand paths.Test plan
.venv/bin/python -m pytest t/unit/bin/test_control.py -q.venv/bin/pre-commit run --files celery/bin/base.py celery/bin/control.py celery/bin/events.py celery/bin/graph.py t/unit/bin/test_control.py.venv/bin/celery --broker amqp://[email protected]:5672// status -t 1issue #9722