Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: celery/celery
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.2.3
Choose a base ref
...
head repository: celery/celery
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.2.6
Choose a head ref
  • 12 commits
  • 12 files changed
  • 4 contributors

Commits on Apr 3, 2022

  1. Expose more debugging information when receiving unkown tasks. (#7404)

    Since the message might have been delivered to the wrong worker due to a
    routing error,
    we need to emit the headers and delivery_info when logging the error as
    well as the message's body.
    thedrow authored Apr 3, 2022
    Configuration menu
    Copy the full SHA
    d230c34 View commit details
    Browse the repository at this point in the history
  2. Added changelog entry.

    thedrow committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    a326cb5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1218d2b View commit details
    Browse the repository at this point in the history
  4. Use importlib instead of deprecated pkg_resources

    This avoids runtime dependency on setuptools.
    nijel authored and thedrow committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    20d8875 View commit details
    Browse the repository at this point in the history
  5. Added changelog entry.

    thedrow committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    bbc7044 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e3f9f6a View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. Bump version: 5.2.5 → 5.2.6

    Omer Katz committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    272b534 View commit details
    Browse the repository at this point in the history
  2. Backport 7406 (#7433)

    * load_extension_class_names - correct module_name
    
    95015a changed over to using importlib rather than pkg_resources,
    unfortunately the object is not exactly the same.
    
    Attempting to start up a celery instance with `django-celery-results`
    installed results in an exception during `load_extension_class_names`;
    
    ```
    During handling of the above exception, another exception occurred:
    
    Traceback (most recent call last):
      File "/usr/lib/python3.10/site-packages/celery/worker/worker.py", line 203, in start
        self.blueprint.start(self)
      File "/usr/lib/python3.10/site-packages/celery/bootsteps.py", line 112, in start
        self.on_start()
      File "/usr/lib/python3.10/site-packages/celery/apps/worker.py", line 136, in on_start
        self.emit_banner()
      File "/usr/lib/python3.10/site-packages/celery/apps/worker.py", line 170, in emit_banner
        ' \n', self.startup_info(artlines=not use_image))),
      File "/usr/lib/python3.10/site-packages/celery/apps/worker.py", line 232, in startup_info
        results=self.app.backend.as_uri(),
      File "/usr/lib/python3.10/site-packages/celery/app/base.py", line 1252, in backend
        self._local.backend = new_backend = self._get_backend()
      File "/usr/lib/python3.10/site-packages/celery/app/base.py", line 955, in _get_backend
        backend, url = backends.by_url(
      File "/usr/lib/python3.10/site-packages/celery/app/backends.py", line 69, in by_url
        return by_name(backend, loader), url
      File "/usr/lib/python3.10/site-packages/celery/app/backends.py", line 47, in by_name
        aliases.update(load_extension_class_names(extension_namespace))
      File "/usr/lib/python3.10/site-packages/celery/utils/imports.py", line 146, in load_extension_class_names
        yield ep.name, ':'.join([ep.module_name, ep.attrs[0]])
    AttributeError: 'EntryPoint' object has no attribute 'module_name'
    ```
    
    Move over to using the direct value should resolve this issue;
    
    ```
    >>> from pkg_resources import iter_entry_points
    >>> list(iter_entry_points('celery.result_backends'))[0].__dict__
    {'name': 'django-cache', 'module_name': 'django_celery_results.backends', 'attrs': ('CacheBackend',), 'extras': (), 'dist': django-celery-results 2.3.0 (/usr/lib/python3.10/site-packages)}
    ```
    vs
    ```
    >>> from importlib.metadata import entry_points
    >>> entry_points().get('celery.result_backends')[0]
    EntryPoint(name='django-cache', value='django_celery_results.backends:CacheBackend', group='celery.result_backends')
    ```
    
    * Update changelog.
    
    Co-authored-by: Damian Zaremba <[email protected]>
    Co-authored-by: Omer Katz <[email protected]>
    3 people authored Apr 5, 2022
    Configuration menu
    Copy the full SHA
    8661e12 View commit details
    Browse the repository at this point in the history
  3. Update PR number in changelog.

    Omer Katz committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    174b00c View commit details
    Browse the repository at this point in the history
  4. Revert update to .bumpversion.cfg

    Omer Katz committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    1a515c5 View commit details
    Browse the repository at this point in the history
  5. Revert "Bump version: 5.2.5 → 5.2.6"

    This reverts commit 272b534.
    Omer Katz committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    7ff7071 View commit details
    Browse the repository at this point in the history
  6. Bump version: 5.2.5 → 5.2.6

    Omer Katz committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    7dfc1fd View commit details
    Browse the repository at this point in the history
Loading