Skip to content

Commit db0da7c

Browse files
ZedingZhangauvipy
andauthored
test: assert exact task replacement nesting levels (#10925)
* test: assert exact nesting levels for task replacements Signed-off-by: ZedingZhang <[email protected]> * test: retain the RPC reply queue across recursive replacements Signed-off-by: ZedingZhang <[email protected]> --------- Signed-off-by: ZedingZhang <[email protected]> Co-authored-by: Asif Saif Uddin {"Auvi":"অভি"} <[email protected]>
1 parent 55e23e8 commit db0da7c

2 files changed

Lines changed: 20 additions & 2 deletions

File tree

‎t/integration/tasks.py‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,19 @@ def add_replaced(self, x, y):
155155
raise self.replace(add.s(x, y))
156156

157157

158+
@shared_task(bind=True)
159+
def record_replaced_task_nesting(self, replacements, nesting=None):
160+
"""Record the nesting level across successive task replacements."""
161+
if nesting is None:
162+
nesting = []
163+
nesting.append(self.request.replaced_task_nesting)
164+
if replacements:
165+
replacement = record_replaced_task_nesting.s(replacements - 1, nesting)
166+
# Keep the caller's result queue when using the RPC backend.
167+
return self.replace(replacement.set(reply_to=self.request.reply_to))
168+
return nesting
169+
170+
158171
@shared_task(bind=True)
159172
def replace_with_chain(self, *args, link_msg=None):
160173
c = chain(identity.s(*args), identity.s())

‎t/integration/test_tasks.py‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
from .conftest import TEST_BACKEND, get_active_redis_channels, get_redis_connection
1919
from .tasks import (AddParameterModel, ClassBasedAutoRetryTask, ExpectedException, add, add_ignore_result,
2020
add_not_typed, add_pydantic, add_pydantic_string_annotations, fail, fail_unpickleable,
21-
print_unicode, reject_then_succeed, reject_without_requeue, retry, retry_once,
22-
retry_once_headers, retry_once_priority, retry_unpickleable, return_properties,
21+
print_unicode, record_replaced_task_nesting, reject_then_succeed, reject_without_requeue, retry,
22+
retry_once, retry_once_headers, retry_once_priority, retry_unpickleable, return_properties,
2323
return_request_time_limits, second_order_replace1, sleeping,
2424
soft_time_limit_must_exceed_time_limit, task_with_declared_time_limits)
2525

@@ -803,6 +803,11 @@ def test_asyncresult_get_cancels_subscription(self, manager):
803803

804804

805805
class test_task_replacement:
806+
@pytest.mark.parametrize('replacements', (0, 1, 3))
807+
def test_replaced_task_nesting_increments(self, manager, replacements):
808+
result = record_replaced_task_nesting.delay(replacements)
809+
assert result.get(timeout=TIMEOUT) == list(range(replacements + 1))
810+
806811
def test_replaced_task_nesting_level_0(self, manager):
807812
@task_received.connect
808813
def task_received_handler(request, **kwargs):

0 commit comments

Comments
 (0)