fix(containers): allow aliases for simple names#1327
Merged
TristonianJones merged 1 commit intoJun 4, 2026
Conversation
Collaborator
|
/gcbrun |
TristonianJones
approved these changes
Jun 4, 2026
TristonianJones
left a comment
TristonianJones
left a comment
Collaborator
There was a problem hiding this comment.
@jnthntatum and @l46kok we should probably make a similar change for C++ and Java alias support since it's a different use case from abbreviations.
Collaborator
|
This change is already present in Java |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1306
Summary
This allows
containers.Aliasto point at a simple name, not only a dotted qualified name.Why
Before this change,
Alias("really_long_package_name", "short")failed validation even though explicit aliases should be able to abbreviate a name without a field selection.Abbrevsstill requires a dotted qualified name, so the stricter abbreviation behavior is preserved.Test plan
go test ./common/containersgo test ./common/containers ./cel ./checker ./interpreter