fix(supertokens): Fix whitespace handling in setup script#158
Merged
Conversation
Tobbe
added
release:fix
✅ Deploy Preview for cedarjs canceled.
|
Tobbe
added a commit
that referenced
this pull request
Jul 6, 2025
I was upgrading to Vitest 3.x and noticed one of our snapshot tests started failing. Looking into it I realized we weren't handling whitespace properly when setting up Supertokens auth. This PR fixes that. I'm guessing this is the Vitest change that caused the diff in snapshots: vitest-dev/vitest#7400 It doesn't say in the PR description, but the [release notes for Vitest 3.1.0](https://github.com/vitest-dev/vitest/releases/tag/v3.1.0), where it was first included, says > This change can cause small amount of very old snapshots to be updated, but there will be no functional change to how they work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was upgrading to Vitest 3.x and noticed one of our snapshot tests started failing. Looking into it I realized we weren't handling whitespace properly when setting up Supertokens auth. This PR fixes that.
I'm guessing this is the Vitest change that caused the diff in snapshots: vitest-dev/vitest#7400
It doesn't say in the PR description, but the release notes for Vitest 3.1.0, where it was first included, says