Repository navigation
Commit 6923b19
authored
chore(ci): drop Windows-specific Node pin, track 24 on all platforms (#2824)
## Why
Windows CI has been pinned to Node `24.15.0` since the libuv
file-watcher
assertion crash (libuv/libuv#5010) was discovered. That reason no longer
applies: the fix shipped in libuv#5152, was cherry-picked into Node via
nodejs/node#65118, and first released in **Node 24.21.0** (2026-09-08).
Investigating #2146 (recurring nightly Windows CI
failures), the
dominant signature is a V8 Maglev JIT crash (exit code `3221226505` /
`STATUS_STACK_BUFFER_OVERRUN`, tracked upstream at nodejs/node#62260).
We
already mitigate this for `cedar dev`'s web server via `--no-maglev`
(`packages/cli/src/commands/dev/devHandler.ts`), but:
- the crash still recurs even with `--no-maglev` present — confirmed
upstream on 2026-09-21 that the flag only reduces the crash rate ~5x, it
doesn't eliminate it
- it also crashes in paths the flag never covers, e.g. `yarn install`
itself (observed in a Sept 10 RSC smoke-tests run)
One upstream reporter also noted their repro doesn't reproduce on Node
`24.19.0`/`22.23.2` while it does on `24.12.0`, suggesting additional
relevant fixes landed in that range too — all after our `24.15.0` pin.
## What
Drop the Windows-only version override in `set-up-job/action.yml` so
Windows tracks the same floating `24` as every other platform, picking
up
both the libuv fix and any V8/Maglev-adjacent fixes in later 24.x
releases.
This isn't expected to fully eliminate the Maglev crashes (upstream is
explicit that `--no-maglev` alone doesn't), but it removes an
unnecessary
constraint and may reduce the frequency. Worth keeping `--no-maglev` and
extending it to the still-uncovered paths (`yarn install`/corepack,
`cedar serve`, api-server-watch, `cedar storybook`) as a separate
follow-up if failures persist after this lands.
## Test plan
- [ ] Nightly Windows run (`.github/workflows/nightly-windows.yml`)
picks
up Node 24.21.0+ and completes without regressions
- [ ] Watch #2146 for a change in failure
frequency/signature
over the following nights1 parent 0f78a53 commit 6923b19
1 file changed
Lines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
48 | | - | |
49 | | - | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
50 | 53 | | |
51 | 54 | | |
52 | 55 | | |
| |||
0 commit comments