Skip to content

PiContactDescriptor - #833

Merged
egonw merged 2 commits into
masterfrom
patch/picontact-fixes
Feb 9, 2022
Merged

PiContactDescriptor#833
egonw merged 2 commits into
masterfrom
patch/picontact-fixes

Conversation

@johnmay

@johnmay johnmay commented Feb 8, 2022

Copy link
Copy Markdown
Member

Fixes #509 - there was an obvious bug as atoms were cloned. The test needed from the bug report updating slightly.

…iour) and add document that pi-systems with a single double bond are not considered conjugated.
@sonarqubecloud

sonarqubecloud Bot commented Feb 8, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@k-ujihara

Copy link
Copy Markdown
Contributor

Thanks @johnmay it looks good.
I consider that we may add compounds containing aromatic bonds, such as styrene, to test case.

@egonw
egonw merged commit 1d71596 into master Feb 9, 2022
@egonw

egonw commented Feb 9, 2022

Copy link
Copy Markdown
Member

I'm good too.

@johnmay
johnmay deleted the patch/picontact-fixes branch February 9, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PiContactDetectionDescriptor doesn't work correctly

3 participants