Skip to content

Update to Apache Jena 4.2 - #748

Merged
egonw merged 7 commits into
masterfrom
update/jena4.2
Jun 4, 2022
Merged

Update to Apache Jena 4.2#748
egonw merged 7 commits into
masterfrom
update/jena4.2

Conversation

@egonw

@egonw egonw commented Sep 21, 2021

Copy link
Copy Markdown
Member

No description provided.

@egonw

egonw commented Sep 21, 2021

Copy link
Copy Markdown
Member Author

@johnmay, one attention point is the support of Java8. Java11 was released in 2018 and is a LTS release, and last week Java17 was released the second LTS release after Java8. Dependencies are dropping Java8 support, maybe we should too?

Comment thread storage/iordf/pom.xml Outdated
<dependency>
<groupId>org.apache.jena</groupId>
<artifactId>jena-arq</artifactId>
<version>4.2.0</version>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

It looks like the latest version for java 1.8 is 3.9.0

@egonw

egonw commented Jan 31, 2022

Copy link
Copy Markdown
Member Author

@johnmay, is 2.8 going to be Java 11?

@johnmay

johnmay commented Jan 31, 2022

Copy link
Copy Markdown
Member

Tricky as we use CDK in products at NextMove and a lot of customers will still be on older systems. I think maybe we do just make the jump though. Perhaps 2.8 -> Java 8 and 2.9 Java 11?

That way I can make Java 11 advisable on the next NextMove product releases then required after that. Sound good?

@johnmay

johnmay commented Jan 31, 2022

Copy link
Copy Markdown
Member

We can actually make just this module Java 11 right now, since I don't use RDF/JENA it wouldn't get in the way.

@egonw egonw assigned egonw and unassigned johnmay Apr 5, 2022
@egonw egonw assigned johnmay and unassigned egonw Apr 5, 2022
@egonw

egonw commented Apr 5, 2022

Copy link
Copy Markdown
Member Author

@johnmay, ready to go into master.

@johnmay

johnmay commented Apr 5, 2022

Copy link
Copy Markdown
Member

Can work out why the pipelines have not run, do we need Java 11?

@egonw

egonw commented Apr 5, 2022

Copy link
Copy Markdown
Member Author

Yes, sorry, we did not migrate in the next upcoming release yet? Sorry, my bad!

@egonw

egonw commented Apr 5, 2022

Copy link
Copy Markdown
Member Author

Part of #823

@egonw egonw mentioned this pull request May 16, 2022
@johnmay

johnmay commented Jun 4, 2022

Copy link
Copy Markdown
Member

@egonw This is good to merge then can do a release

@egonw

egonw commented Jun 4, 2022

Copy link
Copy Markdown
Member Author

@egonw This is good to merge then can do a release

@johnmay, I double check, update to Jena 4.5 (minor update) and then merge in, okay?

@johnmay

johnmay commented Jun 4, 2022

Copy link
Copy Markdown
Member

The minor update doesn't fix anything...? This is a major update.

@egonw

egonw commented Jun 4, 2022

Copy link
Copy Markdown
Member Author

The minor update doesn't fix anything...? This is a major update.

This is the patch I have in mind, updating to the latest dependencies (to make it just a bit more future proof, and I'm sure they fixed stuff in those libs):

diff --git a/storage/iordf/pom.xml b/storage/iordf/pom.xml
index 3fac744a51..3f5b29e04d 100644
--- a/storage/iordf/pom.xml
+++ b/storage/iordf/pom.xml
@@ -17,7 +17,7 @@
         <dependency>
             <groupId>org.apache.jena</groupId>
             <artifactId>jena-core</artifactId>
-            <version>4.4.0</version>
+            <version>4.5.0</version>
             <exclusions>
                 <exclusion>
                     <artifactId>slf4j-log4j12</artifactId>
@@ -32,7 +32,7 @@
         <dependency>
             <groupId>org.apache.jena</groupId>
             <artifactId>jena-arq</artifactId>
-            <version>4.4.0</version>
+            <version>4.5.0</version>
             <exclusions>
                 <exclusion>
                     <artifactId>slf4j-log4j12</artifactId>
@@ -47,7 +47,7 @@
         <dependency>
             <groupId>org.slf4j</groupId>
             <artifactId>slf4j-log4j12</artifactId>
-            <version>1.7.10</version>
+            <version>1.7.36</version>
             <exclusions>
                 <exclusion>
                     <groupId>log4j</groupId>

@egonw

egonw commented Jun 4, 2022

Copy link
Copy Markdown
Member Author

@johnmay, this PR: #867

@johnmay

johnmay commented Jun 4, 2022

Copy link
Copy Markdown
Member

Sorry not clear, make it 4.5.0 you mean?

@egonw

egonw commented Jun 4, 2022

Copy link
Copy Markdown
Member Author

Yes, 4.5 was released very recently as an update to 4.2/4.4. See the PR #867 what I mean.

@johnmay

johnmay commented Jun 4, 2022

Copy link
Copy Markdown
Member

Fixed

@egonw

egonw commented Jun 4, 2022

Copy link
Copy Markdown
Member Author

Do you merge this in, or should I?

@sonarqubecloud

sonarqubecloud Bot commented Jun 4, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

50.0% 50.0% Coverage
1.6% 1.6% Duplication

@egonw
egonw merged commit 07eb931 into master Jun 4, 2022
@johnmay
johnmay deleted the update/jena4.2 branch September 12, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants