Redo @parit's changes for net/undirected reaction depiction on the ne… - #1009
Merged
Conversation
…w reaction drawing code.
Member
Author
|
@parit Please check this redone patch, if happy I will merge. |
…need to remove this test.
Member
Author
|
I've switched the SVG test to mm to see if it is more stable. Otherwise subtle things like font size differences change dimensions and means we can't compare against an "expected" SVG. |
Member
Author
|
OK got to take the test out sorry - too brittle between different systems. |
|
SonarCloud Quality Gate failed.
|
|
@johnmay seems good! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…w reaction drawing code.
Replaces #981