Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version for Jakarta EE #195

Closed
martin-g opened this issue Apr 21, 2021 · 29 comments · Fixed by #230
Closed

Version for Jakarta EE #195

martin-g opened this issue Apr 21, 2021 · 29 comments · Fixed by #230

Comments

@martin-g
Copy link

Please provide a version based on jakarta.** APIs.

Even a milestone/snapshot release would be very welcome!

@ikysil
Copy link
Collaborator

ikysil commented Apr 21, 2021

Yes, that's on the radar. No ETC, obviously.

@martin-g
Copy link
Author

martin-g commented Apr 22, 2021

@ikysil
Copy link
Collaborator

ikysil commented Apr 24, 2021

  • CDI 3.0 (not source-compatible with earlier versions)
  • Weld 4.0.x

@ikysil ikysil added the cdi-3.0 label Apr 24, 2021
@ikysil ikysil added this to the 5.0.0 milestone Apr 24, 2021
@martin-g
Copy link
Author

Draft PR: #196

@ikysil
Copy link
Collaborator

ikysil commented Apr 26, 2021

Hi @martin-g ,

Thank you for the input, that looks interesting.
The change you are proposing is not backwards compatible with CDI specifications before 3.0.

Which begs a question: should we keep that compatibility?

@martin-g
Copy link
Author

martin-g commented Apr 26, 2021

I am not well acquaint with CDI 😕 I am just trying to update Apache Wicket to Servlet API 5.x. wicket-cdi uses cdi-unit for its unit tests.
AFAIK the only change in all new JEE specifications is the change from javax. to jakarta. package. But yes, this makes it binary incompatible with any older versions.
Are there other new things in CDI 3.0 ?

@jin-harmoney
Copy link

@ikysil @martin-g we're also trying to upgrade to EE10 (Wildfly 27), so I bumped into this issue. Can I help out here?

@martin-g
Copy link
Author

martin-g commented Nov 3, 2022

@jin-harmoney Any help to see a new release of cdi-unit is very welcome!

@jin-harmoney
Copy link

I tried, I got quite far actually, but deltaspike is not EE9/10 compatible. It's a huge pain.

There are workarounds to use classifier in the pom:

<dependency>
	<groupId>org.apache.deltaspike.core</groupId>
	<artifactId>deltaspike-core-impl</artifactId>
	<classifier>jakarta</classifier>
	<scope>test</scope>
</dependency>

But there have been commits on the deltaspike repo (https://github.com/rzo1/deltaspike/blob/master/deltaspike/parent/code/pom.xml#L165) that are not yet released related to this classifier.

@jin-harmoney
Copy link

I pinged on the deltaspike repo: apache/deltaspike#128.

@jin-harmoney
Copy link

@martin-g the discussion here is exploding: https://issues.apache.org/jira/browse/DELTASPIKE-1434?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=17643606#comment-17643606.. It doesn't look like we're going to have a jakarta-compatible version soon.

I was wondering if there is a heavy dependency on deltaspike in this project or if it could be replaced somehow? Or maybe excluded if it's not used?

@martin-g
Copy link
Author

Yes, it is sad!

@martin-g
Copy link
Author

That's nice !
@jin-harmoney Can you continue now with your quest ?

@jin-harmoney
Copy link

@martin-g yes! I'll keep you posted on our progress.

@jin-harmoney
Copy link

jin-harmoney commented May 15, 2024

@ikysil we're working on a Jakarta compatible version, but we were wondering if we should branch from master or from tag 4.1.0, because there is quite some stuff on master that is not yet released.

@ikysil
Copy link
Collaborator

ikysil commented May 15, 2024

Hi @jin-harmoney

Yeah, that's true - there are a lot of stuff on master which is not released yet.

Do you see the changes for Jakarta compatible version as straightforward?
Or some major refactorings are required?
New Maven modules needed?

@har-cpol
Copy link

Hello, @ikysil

I'm working with @jin-harmoney on the jakarta compatible version.
At the moment I'm working on master codebase.

Just checked and so far our changes are straightforward.

  • updates of package names to jakarta
  • Some minor changes where jakarta classes are a bit different from javax. (servlet classes, annotatedTypeBuilder)

No new maven modules - just updated versions in pom

@ikysil
Copy link
Collaborator

ikysil commented May 27, 2024

Let's keep your work on top of master.
I will prepare a new release with existing changes.

@ikysil
Copy link
Collaborator

ikysil commented May 28, 2024

Hello @jin-harmoney @har-cpol

It's strange that Apache web site is not updated still - it lists 36th Release (1.9.4) (2020-06-12) as the latest release.

Am I looking at wrong address?
https://deltaspike.apache.org/news.html

@ikysil
Copy link
Collaborator

ikysil commented May 31, 2024

A few observations on Deltaspike 2.0:

  • it is neither source nor binary compatible with 1.x series
  • it requires Java 11

@martin-g
Copy link
Author

That's fine!
Almost all projects moved to Java 17+ while doing the migration to jakarta.**
Java 8 is way too old!

@ikysil
Copy link
Collaborator

ikysil commented May 31, 2024

Sure, that's fine for the future MAJOR release of cdi-unit.

I'm looking at this from the next 4.x release perspective where Java 8 compatibility is still a thing.

@martin-g
Copy link
Author

Do you mean that you want to release cdi-unit for jakarta.** in a minor version ?

@ikysil
Copy link
Collaborator

ikysil commented May 31, 2024

No, I'm preparing to release current master as 4.2.0.

All the other work goes to 5+

@ikysil
Copy link
Collaborator

ikysil commented May 31, 2024

JakartaEE is one of the features for the next MAJOR release.

Other items (I am aware of) are:

@ikysil ikysil linked a pull request Jun 20, 2024 that will close this issue
@ikysil
Copy link
Collaborator

ikysil commented Jun 22, 2024

PR #230 has been merged into the master.

I'm closing this issue and proceeding with a EA release.

@ikysil
Copy link
Collaborator

ikysil commented Jun 22, 2024

Version 5.0.0-EA1 has been published.
pkg:maven/io.github.cdi-unit/[email protected]

Please check and report any issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants