feat: preferred_labels config for non-canonical good-first-issue labels#60
Merged
feat: preferred_labels config for non-canonical good-first-issue labels#60
Conversation
|
✅ PR template check passed. Thanks for filling out the template. |
…ls (closes #1) Adds `preferred_labels` config key (default: "good first issue", "good-first-issue", "help wanted"). scan and issues now query each label separately and dedupe results by issue number, so repos using label variants like "Good first issue 🎉" surface in scan output without additional configuration. Set with: gem-contribute config set preferred_labels "label1,label2" Also updates CHANGELOG for this change and for #10 (owner-of-upstream message) which shipped in a parallel PR. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
The Configuration table previously only listed clone_root. Expand it to cover all five keys (clone_root, editor, ai_tool, comment_on_fix, preferred_labels) with defaults and usage notes. Add YAML example for comment_on_fix_overrides. Update scan/issues command descriptions to say "contributable" rather than hard-coding "good first issue". Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
cdhagmann
force-pushed
the
preferred-labels-config
branch
from
c9990fa to
9ae5fac
Compare
Check off #1, #10, #40–#43, #45, #54 in the Phase 6 checklist with PR references. Update "In flight" (PR #55 long merged), "What hasn't started" (README/CONTRIBUTING done; #9 and plugin smoke deferred), and "What's already done" to summarise the Phase 6 landing. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
…sues #63 and #64 Q3a resolved: bare bundle/gem contribute runs scan, matching bundle fund. Tracked as #63. Update OPEN_QUESTIONS and ROADMAP with the decision. Issue #64 opened for visual identity / branding design. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
…#63 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
preferred_labelsconfig key so users can customise which issue labelsscanandissuestreat as "contributable". Defaults to["good first issue", "good-first-issue", "help wanted"]. Because GitHub's label API applies AND semantics when multiple labels are joined in one request, each label is fetched separately and results are deduped client-side by issue number.Linked issue / ADR
Closes #1. Touches ADR-0005 (label normalisation is still out of scope — this is label selection, not normalisation).
Working agreement
bin/rubocopandbin/rspecpass locallyAsync/ synchronous shellouts)Test plan
bundle exec rspec spec/gem_contribute/config_spec.rb— preferred_labels default, array override, comma-string coercionbundle exec rspec spec/gem_contribute/cli/scan_spec.rb spec/gem_contribute/cli/issues_spec.rb— per-label fetch, dedupbundle exec rspec— all passingbin/rubocop— no offensesNotes for reviewer
gem-contribute config set preferred_labels "bug,help wanted"coerces the comma-separated string to an array at write time, so the YAML is always an array. Reading always returns an Array regardless.