Repository navigation
ci(review): the comment that carries the verdict links the review run (Cortex ADR-1130) - #497
Merged
Merged
Conversation
… (Cortex ADR-1130) The resolver counts a verdict only when its comment links a successful review run of the head. The prompt asked for one final verdict line and did not say where: on #495 the review posted with gh pr comment carried the verdict and no link, the tracking comment the link and no verdict, so the approve cannot be read. The prompt now gives the run's link and says to put it just before the verdict line in every comment that carries it. Same change as cdeust/Cortex#975. Co-Authored-By: Claude Fable 5.2 <[email protected]> Claude-Session: https://claude.ai/code/session_018kyZYsWnKSjpX4oNV19PCF Signed-off-by: Claude <[email protected]>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
CHANGELOG conflict with the contract entry (#495): both entries kept. Co-Authored-By: Claude Fable 5.2 <[email protected]> Claude-Session: https://claude.ai/code/session_018kyZYsWnKSjpX4oNV19PCF Signed-off-by: Claude <[email protected]>
12 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The resolver counts a verdict only when its comment links a successful
claude-review.ymlrun of the head. The review prompt asked for one final verdict line and did not say where. The action posts two comments: its tracking comment, which links the run, and the review posted withgh pr comment, which does not.On #495 the verdict went only into the second one (tracking comment 6767209801: link, no verdict; review comment 6767255997: verdict, no link), so its approve cannot be read and the merge is held. Same defect and same fix as cdeust/Cortex#975 (merged), where it held cdeust/Cortex#973.
What
claude-review.yml: the prompt gives the run's link and says to put it just before the verdict line in every comment that carries it. The resolver is unchanged.scripts/tests/test_ci_review_budget.py: the prompt carries the link, after the verdict instruction.Checks
python3 -m unittest discover -s scripts/tests -p "test_ci_review*.py": OK.Limits
The rule lives in a prompt: a review that ignores it is held as before, with the same notice. This pull request edits
claude-review.yml, so the action does not review it.Metric
Pull requests with an approve and green checks that the resolver holds with "Claude has not posted a verdict on this head": one today in this repository (#495), expected zero.
Generated by Claude Code