Repository navigation
ci(review): one review workflow and budget script for every repository - #980
Merged
Merged
Conversation
Three things kept the other repositories from holding Cortex's claude-review.yml and ci_review_budget.py byte for byte: ci-autonome is private and needs the pinned action's fetch authorized, architect-os runs three reviewers where the prompt said five, and claude-mods refuses a GITHUB_OUTPUT outside RUNNER_TEMP. The fetch step is now here and runs only on a private repository, the prompt names no count, and the output check is taken from claude-mods. Tests: tests_py/scripts 1951 passed, 15 skipped (test_ci_mutation_scope deselected: it shells out to uv run, which needs torch and this environment cannot download it); ruff and the craftsmanship gate pass. Co-Authored-By: Claude Fable 5.2 <[email protected]> Claude-Session: https://claude.ai/code/session_018kyZYrKg46KKYpvLPXcW4M Signed-off-by: Claude <[email protected]>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Owner direction 2026-11-10: the CI of every repository must be identical to Cortex's. Three things kept the other repositories from holding Cortex's
claude-review.ymlandscripts/ci_review_budget.pybyte for byte. This pull request removes them, so the two files can be copied unchanged into every repository.Authorize pinned action fetchstep Cortex lacked (the pinned action fetches the PR head before its own git auth; run 42785671958 of ci-autonome failed withcould not read Username). The step is now here, withif: github.event.repository.private, so it does not run on Cortex.GITHUB_OUTPUToutsideRUNNER_TEMP(CodeQL py/path-injection).output_file()is taken from it.No issue is linked.
This pull request cannot be reviewed by the review workflow
The review action skips a branch whose
claude-review.ymldiffers from the default branch's, and its run still endssuccesswith no verdict. This branch edits that file, so no verdict will ever be posted on it. The owner asked for these pull requests to be merged without review once CI is green.Type of change
Test plan
pytest tests_py/scripts: 1951 passed, 15 skipped.tests_py/scripts/test_ci_mutation_scope.pywas deselected: it shells out touv run, which syncs torch, and this environment cannot download it.test_the_output_file_must_sit_inside_the_runner_temp; the two CLI tests now setRUNNER_TEMP.ruff check,ruff format --check(0.17.3) on the changed Python files andpython scripts/check_craftsmanship.py: clean.Reviewer checklist
Generated by Claude Code