Repository navigation
ci(review): the comment that carries the verdict links the review run (ADR-1130) - #975
Merged
Merged
Conversation
… (ADR-1130) The resolver counts a verdict only when its comment links a successful review run of the head (ADR-1121). The prompt asked for one final verdict line and did not say where. A review posted with gh pr comment carried the verdict and no link, the tracking comment carried the link and no verdict, and the resolver held the merge: #973, approved at 12:17 UTC and green at 12:36, was not merged (resolver run 42816975550, "Claude has not posted a verdict on this head"). The prompt now gives the run's link and says to put it just before the verdict line in every comment that carries it. The resolver is unchanged. Co-Authored-By: Claude Fable 5.2 <[email protected]> Claude-Session: https://claude.ai/code/session_018kyZYsWnKSjpX4oNV19PCF Signed-off-by: Claude <[email protected]>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
cdeust
pushed a commit
that referenced
this pull request
Nov 10, 2026
Notes of review 1 of #973, taken in one push because that review's verdict cannot be read by the resolver (its comment does not link the run, fixed for later reviews by ADR-1130, #975): the low-risk Dependabot merge and the "do not merge" title, and what a pull request cut down after its third review waits for. Co-Authored-By: Claude Fable 5.2 <[email protected]> Claude-Session: https://claude.ai/code/session_018kyZYsWnKSjpX4oNV19PCF Signed-off-by: Claude <[email protected]>
cdeust
added a commit
to cdeust/ai-architect-mcp-spec
that referenced
this pull request
Nov 10, 2026
… (Cortex ADR-1130) (#203) The resolver counts a verdict only when its comment links a successful review run of the head. The prompt asked for one final verdict line and did not say where: a review posted with gh pr comment can carry the verdict and no link, and the approve then cannot be read. The prompt now gives the run's link and says to put it just before the verdict line in every comment that carries it. Same change as cdeust/Cortex#975. Claude-Session: https://claude.ai/code/session_018kyZYsWnKSjpX4oNV19PCF Signed-off-by: Claude <[email protected]> Co-authored-by: Claude <[email protected]>
This was referenced Nov 10, 2026
cdeust
added a commit
to cdeust/cortex-vision
that referenced
this pull request
Nov 10, 2026
… (Cortex ADR-1130) (#8) The resolver counts a verdict only when its comment links a successful review run of the head. The prompt asked for one final verdict line and did not say where: a review posted with gh pr comment can carry the verdict and no link, and the approve then cannot be read. The prompt now gives the run's link and says to put it just before the verdict line in every comment that carries it. Same change as cdeust/Cortex#975. Claude-Session: https://claude.ai/code/session_018kyZYsWnKSjpX4oNV19PCF Signed-off-by: Claude <[email protected]> Co-authored-by: Claude <[email protected]>
cdeust
added a commit
to cdeust/cortex-voice
that referenced
this pull request
Nov 10, 2026
… (Cortex ADR-1130) (#8) The resolver counts a verdict only when its comment links a successful review run of the head. The prompt asked for one final verdict line and did not say where: a review posted with gh pr comment can carry the verdict and no link, and the approve then cannot be read. The prompt now gives the run's link and says to put it just before the verdict line in every comment that carries it. Same change as cdeust/Cortex#975. Claude-Session: https://claude.ai/code/session_018kyZYsWnKSjpX4oNV19PCF Signed-off-by: Claude <[email protected]> Co-authored-by: Claude <[email protected]>
cdeust
added a commit
to cdeust/zetetic-team-subagents
that referenced
this pull request
Nov 10, 2026
… (Cortex ADR-1130) (#246) The resolver counts a verdict only when its comment links a successful review run of the head. The prompt asked for one final verdict line and did not say where: a review posted with gh pr comment can carry the verdict and no link, and the approve then cannot be read. The prompt now gives the run's link and says to put it just before the verdict line in every comment that carries it, here and in the copy render-ci delivers. Same change as cdeust/Cortex#975. Claude-Session: https://claude.ai/code/session_018kyZYsWnKSjpX4oNV19PCF Signed-off-by: Claude <[email protected]> Co-authored-by: Claude <[email protected]>
cdeust
added a commit
to cdeust/claude-mods
that referenced
this pull request
Nov 10, 2026
… (Cortex ADR-1130) (#69) The resolver counts a verdict only when its comment links a successful review run of the head. The prompt asked for one final verdict line and did not say where: a review posted with gh pr comment can carry the verdict and no link, and the approve then cannot be read. The prompt now gives the run's link and says to put it just before the verdict line in every comment that carries it. Same change as cdeust/Cortex#975. Claude-Session: https://claude.ai/code/session_018kyZYsWnKSjpX4oNV19PCF Signed-off-by: Claude <[email protected]> Co-authored-by: Claude <[email protected]>
cdeust
added a commit
to cdeust/cortex-viz
that referenced
this pull request
Nov 10, 2026
… (Cortex ADR-1130) (#234) The resolver counts a verdict only when its comment links a successful review run of the head. The prompt asked for one final verdict line and did not say where: a review posted with gh pr comment can carry the verdict and no link, and the approve then cannot be read. The prompt now gives the run's link and says to put it just before the verdict line in every comment that carries it. Same change as cdeust/Cortex#975. Claude-Session: https://claude.ai/code/session_018kyZYsWnKSjpX4oNV19PCF Signed-off-by: Claude <[email protected]> Co-authored-by: Claude <[email protected]>
cdeust
added a commit
to cdeust/session-optimizer
that referenced
this pull request
Nov 10, 2026
… (Cortex ADR-1130) (#108) The resolver counts a verdict only when its comment links a successful review run of the head. The prompt asked for one final verdict line and did not say where: a review posted with gh pr comment can carry the verdict and no link, and the approve then cannot be read. The prompt now gives the run's link and says to put it just before the verdict line in every comment that carries it. Same change as cdeust/Cortex#975. Claude-Session: https://claude.ai/code/session_018kyZYsWnKSjpX4oNV19PCF Signed-off-by: Claude <[email protected]> Co-authored-by: Claude <[email protected]>
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 10, 2026
…973) * docs(agents): state the CI contract every agent and routine follows The scheduled routines were written before the review contract: on 2026-11-10 they measured branches against the main branch and rebased them with a forced push, commented on approved pull requests (#968) and opened pull requests while another was in flight (#971, #972). Their prompt tells them to read CLAUDE.md and docs/ and to apply the repository's standards, so the rules "Review rounds" does not hold yet are written next to it, and both are said to win over a less restrictive routine prompt. Co-Authored-By: Claude Fable 5.2 <[email protected]> Claude-Session: https://claude.ai/code/session_018kyZYsWnKSjpX4oNV19PCF Signed-off-by: Claude <[email protected]> * docs(agents): rule 1 names the two merges the verdict does not decide Notes of review 1 of #973, taken in one push because that review's verdict cannot be read by the resolver (its comment does not link the run, fixed for later reviews by ADR-1130, #975): the low-risk Dependabot merge and the "do not merge" title, and what a pull request cut down after its third review waits for. Co-Authored-By: Claude Fable 5.2 <[email protected]> Claude-Session: https://claude.ai/code/session_018kyZYsWnKSjpX4oNV19PCF Signed-off-by: Claude <[email protected]> --------- Signed-off-by: Claude <[email protected]> Co-authored-by: Claude <[email protected]>
cdeust
added a commit
to cdeust/ai-architect-mcp-codebase
that referenced
this pull request
Nov 10, 2026
… (Cortex ADR-1130) (#497) The resolver counts a verdict only when its comment links a successful review run of the head. The prompt asked for one final verdict line and did not say where: on #495 the review posted with gh pr comment carried the verdict and no link, the tracking comment the link and no verdict, so the approve cannot be read. The prompt now gives the run's link and says to put it just before the verdict line in every comment that carries it. Same change as cdeust/Cortex#975. Claude-Session: https://claude.ai/code/session_018kyZYsWnKSjpX4oNV19PCF Signed-off-by: Claude <[email protected]> Co-authored-by: Claude <[email protected]>
cdeust
pushed a commit
that referenced
this pull request
Nov 10, 2026
Conflict: wiki/manifest.json, the ADR-1128 and ADR-1129 entries are both kept. The ADR-1130 entry is added: its decision file came with #975 without its manifest line, which made check_project_wiki.py fail on main. Co-Authored-By: Claude Fable 5.2 <[email protected]> Claude-Session: https://claude.ai/code/session_018kyZYsWnKSjpX4oNV19PCF Signed-off-by: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The resolver counts a verdict only when its comment links a successful
claude-review.ymlrun of the head (ADR-1121). The review prompt asked for one final verdict line and did not say where. The action posts two comments: its tracking comment, which links the run, and the review posted withgh pr comment, which does not.On #973 the verdict went only into the second one:
Verdict:Resolver run 42816975550 then read
merge held: Claude has not posted a verdict on this head. #973 was approved at 12:17 UTC, green at 12:36, and stays unmerged. Pull requests whosegh pr commentcall was refused merged, because the review then went into the tracking comment: whether an approve is read depended on that.What
claude-review.yml: the prompt gives the run's link and says to put it just before the verdict line in every comment that carries it. The resolver is unchanged.tests_py/scripts/test_ci_review_budget.py: the prompt carries the link, after the verdict instruction.Checks
tests_py/scripts/test_ci_review_budget.py,test_ci_review_dictates_merge.py,test_docs_index_links.py,test_check_doc_claims.py: 187 passed.scripts/check_doc_claims.py: OK. Six tests oftest_ci_mutation_scope.pyfail in my sandbox with and without this change.Limits
The rule lives in a prompt: a review that ignores it is held as before, with the same notice. This pull request edits
claude-review.yml, so the action does not review it (it refuses a workflow that differs from the default branch).Metric
Pull requests with an approve and green checks that the resolver holds with "Claude has not posted a verdict on this head": one today (#973), expected zero.
Generated by Claude Code