|
| 1 | +"""A prospective trigger carries no text into another project (GHSA-7848-qh48-mx2w). |
| 2 | +
|
| 3 | +Review 1 of pull request 981: `remember` turns a phrase such as `TODO:` into a |
| 4 | +`keyword_match` trigger, and a trigger used to fire in every project whose first |
| 5 | +message or query shared a keyword. The write passed every domain and directory |
| 6 | +check, so the advisory's primitive stayed open through this channel. Reproduced |
| 7 | +on the real handlers and store with two git repositories, `alpha` and `beta`. |
| 8 | +""" |
| 9 | + |
| 10 | +from __future__ import annotations |
| 11 | + |
| 12 | +import pytest |
| 13 | + |
| 14 | +from mcp_server.core.prospective import trigger_in_scope |
| 15 | +from mcp_server.errors import ValidationError |
| 16 | +from mcp_server.handlers import _write_scope, query_methodology |
| 17 | +from mcp_server.handlers.create_trigger import handler as create_trigger |
| 18 | +from mcp_server.handlers.recall_helpers import inject_triggered_memories |
| 19 | +from mcp_server.handlers.remember import handler as remember_handler |
| 20 | +from tests_py.handlers import test_ghsa_7848_cross_project_write as _base |
| 21 | + |
| 22 | +projects = _base.projects # alpha and beta under `dev`; the session runs in beta |
| 23 | + |
| 24 | +MARKER = "rotate the GHSA7848 deploy credentials" |
| 25 | +MESSAGE = "please rotate the deploy credentials" |
| 26 | + |
| 27 | + |
| 28 | +def _fired(directory) -> list[str]: |
| 29 | + fired = query_methodology._get_fired_triggers(str(directory), MESSAGE) |
| 30 | + return [t["content"] for t in fired] |
| 31 | + |
| 32 | + |
| 33 | +async def _write_todo(projects) -> None: |
| 34 | + await remember_handler( |
| 35 | + { |
| 36 | + "content": f"TODO: {MARKER}", |
| 37 | + "directory": str(projects / "beta"), |
| 38 | + "force": True, |
| 39 | + } |
| 40 | + ) |
| 41 | + |
| 42 | + |
| 43 | +@pytest.mark.asyncio |
| 44 | +async def test_a_todo_written_in_beta_does_not_fire_in_alpha(projects): |
| 45 | + await _write_todo(projects) |
| 46 | + assert _fired(projects / "alpha") == [] |
| 47 | + |
| 48 | + |
| 49 | +@pytest.mark.asyncio |
| 50 | +async def test_a_todo_written_in_beta_still_fires_in_beta(projects): |
| 51 | + await _write_todo(projects) |
| 52 | + assert _fired(projects / "beta") == [MARKER] |
| 53 | + |
| 54 | + |
| 55 | +@pytest.mark.asyncio |
| 56 | +async def test_recall_in_alpha_does_not_inject_a_trigger_of_beta(projects, monkeypatch): |
| 57 | + await _write_todo(projects) |
| 58 | + store = query_methodology._try_get_memory_store() |
| 59 | + in_beta = inject_triggered_memories([], MESSAGE, store) |
| 60 | + monkeypatch.setenv(_write_scope.SESSION_ENV, str(projects / "alpha")) |
| 61 | + in_alpha = inject_triggered_memories([], MESSAGE, store) |
| 62 | + assert [r["content"] for r in in_beta] == [f"TODO: {MARKER}"] |
| 63 | + assert in_alpha == [] |
| 64 | + |
| 65 | + |
| 66 | +@pytest.mark.asyncio |
| 67 | +async def test_create_trigger_refuses_another_projects_directory(projects): |
| 68 | + with pytest.raises(ValidationError, match="CORTEX_CROSS_PROJECT_WRITES=alpha"): |
| 69 | + await create_trigger( |
| 70 | + { |
| 71 | + "content": MARKER, |
| 72 | + "trigger_condition": "deploy", |
| 73 | + "target_directory": str(projects / "alpha"), |
| 74 | + } |
| 75 | + ) |
| 76 | + |
| 77 | + |
| 78 | +@pytest.mark.asyncio |
| 79 | +async def test_create_trigger_without_a_directory_stays_in_the_session(projects): |
| 80 | + made = await create_trigger({"content": MARKER, "trigger_condition": "deploy"}) |
| 81 | + assert made["target_directory"] == str(projects / "beta") |
| 82 | + |
| 83 | + |
| 84 | +@pytest.mark.parametrize( |
| 85 | + ("target", "root", "expected"), |
| 86 | + [ |
| 87 | + ("/dev/beta", "/dev/beta", True), |
| 88 | + ("/dev/beta", "/dev/beta/src", True), |
| 89 | + ("/dev/beta", "/dev/alpha", False), |
| 90 | + ("", "/dev/beta", False), |
| 91 | + (None, "/dev/beta", False), |
| 92 | + ("/dev/beta", None, False), |
| 93 | + ], |
| 94 | +) |
| 95 | +def test_a_trigger_fires_only_where_its_directory_is_served(target, root, expected): |
| 96 | + trigger = {"trigger_type": "keyword_match", "target_directory": target} |
| 97 | + assert trigger_in_scope(trigger, root) is expected |
| 98 | + |
| 99 | + |
| 100 | +def test_a_directory_trigger_is_decided_by_its_own_condition(): |
| 101 | + trigger = {"trigger_type": "directory_match", "target_directory": "/dev/beta"} |
| 102 | + assert trigger_in_scope(trigger, "/dev/alpha") is True |
0 commit comments