Skip to content

Commit afc89e5

Browse files
cdeustclaude
andcommitted
refactor(remember): team-scope rule in core/team_scope.py (#561)
The attested-decision predicate (deliberate class, trusted origin, decision cue, agent context) is business logic: it moves out of the handler into a pure core module next to propagates_to_team, which keeps remember.py from growing further past its baselined size and gives the rule direct unit tests. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
1 parent 18f97fd commit afc89e5

6 files changed

Lines changed: 65 additions & 30 deletions

File tree

‎mcp_server/core/global_detector.py‎

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -257,16 +257,6 @@ def _category_for_phrase(phrase: str) -> str:
257257
return "unknown"
258258

259259

260-
def propagates_to_team(is_decision: bool, agent_context: str) -> bool:
261-
"""True when a decision written under an agent context must be team-visible.
262-
263-
Transactive Memory Systems (Wegner 1987): the team knows WHAT was decided
264-
regardless of WHO decided it, so the decision is marked is_global.
265-
266-
source: ADR-0200"""
267-
return is_decision and bool(agent_context)
268-
269-
270260
def resolve_global_scope(
271261
content: str,
272262
tags: list[str],
@@ -277,7 +267,7 @@ def resolve_global_scope(
277267
"""Return (is_global, reason) for a new memory.
278268
279269
An explicit request wins, then team propagation of decisions (the caller
280-
evaluates propagates_to_team), then the content detector.
270+
evaluates team_scope.is_team_decision), then the content detector.
281271
282272
source: ADR-0200
283273
source: ADR-0184"""

‎mcp_server/core/memory_ingest.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
)
1313
from mcp_server.observability import silent_failure
1414
from mcp_server.core import knowledge_graph, write_post_store
15-
from mcp_server.core.global_detector import propagates_to_team
15+
from mcp_server.core.team_scope import propagates_to_team
1616

1717

1818
def ingest_memory(

‎mcp_server/core/team_scope.py‎

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
"""Team scope of decisions: Transactive Memory Systems (Wegner 1987).
2+
3+
The team knows WHAT was decided regardless of WHO decided it, so a
4+
decision written under an agent context is marked is_global.
5+
6+
source: ADR-0200"""
7+
8+
from __future__ import annotations
9+
10+
from mcp_server.core import capture_origin, thermodynamics
11+
from mcp_server.shared.write_class import DELIBERATE
12+
13+
14+
def propagates_to_team(is_decision: bool, agent_context: str) -> bool:
15+
"""True when a decision written under an agent context must be team-visible.
16+
17+
source: ADR-0200"""
18+
return is_decision and bool(agent_context)
19+
20+
21+
def is_team_decision(
22+
content: str, origin: str, write_class: str, agent_context: str
23+
) -> bool:
24+
"""A decision cue counts for team scope only on a deliberate write from an
25+
origin allowed content-derived privileges (ADR-0114), under an agent context.
26+
27+
source: ADR-0200"""
28+
attested = (
29+
write_class == DELIBERATE
30+
and capture_origin.may_bypass_write_gate_on_content(origin)
31+
and thermodynamics.is_decision_content(content)
32+
)
33+
return propagates_to_team(attested, agent_context)

‎mcp_server/handlers/remember.py‎

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@
1616
from mcp_server.errors import ValidationError
1717
from mcp_server.handlers._telemetry_wrap import instrument
1818
from mcp_server.core.domain_detector import detect_domain
19-
from mcp_server.core.global_detector import propagates_to_team, resolve_global_scope
19+
from mcp_server.core.global_detector import resolve_global_scope
20+
from mcp_server.core.team_scope import is_team_decision
2021
from mcp_server.handlers.remember_helpers import (
2122
apply_modulations,
2223
evaluate_gate,
@@ -161,18 +162,6 @@ def _resolved_origin(args: dict[str, Any], write_class: str) -> str:
161162
return origin
162163

163164

164-
def _is_attested_decision(content: str, origin: str, write_class: str) -> bool:
165-
"""A decision cue counts for team scope only on a considered write
166-
(deliberate class) from an origin allowed content-derived privileges.
167-
168-
source: ADR-0200"""
169-
return (
170-
write_class == write_class_module.DELIBERATE
171-
and capture_origin.may_bypass_write_gate_on_content(origin)
172-
and thermodynamics.is_decision_content(content)
173-
)
174-
175-
176165
def _prepare_request(args: dict, store: MemoryStore, write_class: str) -> GateRequest:
177166
domain = _resolve_domain(args.get("directory", ""), args.get("domain", ""))
178167
origin = _resolved_origin(args, write_class)
@@ -297,9 +286,8 @@ async def _handler_impl(
297286
content,
298287
tags,
299288
explicit=bool(is_global),
300-
team_decision=propagates_to_team(
301-
_is_attested_decision(content, resolved_origin, resolved_write_class),
302-
agent_topic or "",
289+
team_decision=is_team_decision(
290+
content, resolved_origin, resolved_write_class, agent_topic or ""
303291
),
304292
)
305293

‎mcp_server/hooks/session_start.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ def _fetch_team_decisions(conn, exclude_ids: set) -> list[dict]:
198198
Implements the directory layer of Transactive Memory Systems
199199
(Wegner 1987): team members know WHAT was decided, regardless
200200
of WHO decided it. Decisions auto-propagate via is_global=TRUE,
201-
set at write time by global_detector.propagates_to_team.
201+
set at write time by team_scope.is_team_decision.
202202
203203
source: ADR-0498"""
204204
try:

‎tests_py/core/test_global_scope_resolution.py‎

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44

55
from __future__ import annotations
66

7-
from mcp_server.core.global_detector import propagates_to_team, resolve_global_scope
7+
from mcp_server.core.global_detector import resolve_global_scope
8+
from mcp_server.core.team_scope import is_team_decision, propagates_to_team
89

910
_DECISION = "Decision: we keep the ledger layout because the dossier needs it"
1011
_PLAIN = "plain note about the weather in the fixture"
@@ -47,3 +48,26 @@ def test_detector_still_marks_cross_project_content(self):
4748
)
4849
assert is_global is True
4950
assert reason.startswith("global_")
51+
52+
53+
class TestIsTeamDecision:
54+
def test_deliberate_trusted_decision_under_agent(self):
55+
assert is_team_decision(_DECISION, "deliberate", "deliberate", "cortex")
56+
57+
def test_local_action_origin_is_trusted(self):
58+
assert is_team_decision(_DECISION, "local_action", "deliberate", "cortex")
59+
60+
def test_network_origin_is_refused(self):
61+
assert not is_team_decision(_DECISION, "network", "deliberate", "cortex")
62+
63+
def test_unknown_origin_is_refused(self):
64+
assert not is_team_decision(_DECISION, "unknown", "deliberate", "cortex")
65+
66+
def test_auto_capture_is_refused(self):
67+
assert not is_team_decision(_DECISION, "local_action", "auto", "cortex")
68+
69+
def test_plain_content_is_not_a_decision(self):
70+
assert not is_team_decision(_PLAIN, "deliberate", "deliberate", "cortex")
71+
72+
def test_no_agent_context_stays_local(self):
73+
assert not is_team_decision(_DECISION, "deliberate", "deliberate", "")

0 commit comments

Comments
 (0)